fix(repositories): add icons to the Artifacts and Upload tabs#480
Open
dragonpaw wants to merge 1 commit into
Open
fix(repositories): add icons to the Artifacts and Upload tabs#480dragonpaw wants to merge 1 commit into
dragonpaw wants to merge 1 commit into
Conversation
Every TabsTrigger in the repo-detail tab strip rendered a leading lucide icon except Artifacts and Upload, leaving those two visually inconsistent with their siblings (Packages, Members, Security, Notifications, Settings). Add `FileArchive` to the Artifacts tab and `Upload` to the Upload tab, matching the existing `size-3.5 mr-1` icon pattern. A regression test renders the full tab strip (admin + virtual repo) and asserts every tab carries an icon, so the same omission can't recur on a future tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the repository detail screen, every tab in the
TabsListrendered a leading lucide icon except Artifacts and Upload, leaving those two visually inconsistent with their siblings (Packages, Members, Security, Notifications, Settings). The icon was simply never added when those two triggers were written.This adds
FileArchiveto the Artifacts tab andUploadto the Upload tab, using the samesize-3.5 mr-1pattern as the other tabs.FileArchiveis distinct fromPackage/Boxes, which already denote "Packages" in the tab strip and sidebar.Test Checklist
The new test
repo-detail-content.test.tsxrenders the full tab strip (admin + virtual repo so all seven tabs are present) and asserts every tab carries an icon — chosen over asserting just the two so the same omission cannot recur on a future tab. Verified it fails onmain(flags exactlyArtifacts, Upload) and passes with this change.UI Changes
currentColorlike the othersCloses #479