fix(install): disambiguate tilth cargo install package name - #71
Merged
Conversation
Running the real (network) installer to pick up the prior fixes surfaced a live failure: `cargo install --git <tilth-repo> --rev <sha> --force` aborted with "multiple packages with binaries found: tilth, tilth-fuzz". The upstream tilth repo now carries a fuzz/ package alongside the tilth binary crate, and `cargo install --git` searches the whole cloned repo for any Cargo.toml with a [[bin]] — unlike --path, which targets one manifest and was unaffected (--local install is fine). RTK's equivalent invocation is unaffected (no second binary package in its repo); ICM's already passed an explicit icm-cli package name. Both tilth call sites (pinned --rev branch and the unpinned upstream-HEAD fallback) now pass `tilth` explicitly, matching ICM's pattern. Verified against the real upstream repo. 278 bats / 72 pytest, 0 fail. Version 1.15.20 to 1.15.21. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo install --git <tilth-repo> --rev <sha> --forceaborts with "multiple packages with binaries found: tilth, tilth-fuzz".artificemachine/tilthnow carries afuzz/package alongside thetilthbinary crate.cargo install --gitsearches the whole cloned repo for anyCargo.tomlwith a[[bin]], so an unqualified install is ambiguous.--path(the--localinstall mode) is unaffected since it targets one manifest directly.--revbranch and the unpinned upstream-HEAD fallback) now passtilthexplicitly as the package name, matching the pattern ICM's install already used (icm-cli).cargo install --git https://github.com/artificemachine/tilth --rev <pinned sha> tilth --forcesucceeds.Test plan
install: tilth cargo install disambiguates the package name (repo also has a fuzz crate)asserts the dry-run cargo command carries the explicittilthpackage arg🤖 Generated with Claude Code