Repository navigation
Radical reform: replace the codebase - #504
Merged
Merged
Conversation
Codex streams every subagent's frames on the same app-server connection. Message deltas, turn starts and settlements, and token usage were read without their thread, so a child agent's words appeared as the parent's reply, a child's turn could replace or settle the root turn, and its usage counted as the root's. Frames that claim another thread now stay out of the root channel. Subagents were also never shown: the decoder listened for discovery methods the app-server does not send and dropped `collabAgentToolCall` items. A child's `thread/started` and the root's spawn and wait calls now become `subagent` tool rows keyed by the child thread and named by its nickname, and the child's turns and reported states settle them, so Codex agents appear in the inspector like Claude's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rewrite Artisan as the shape RADICAL_REFORM.md decided and ARCHITECTURE.md describes: ~100k lines in 17 crates instead of ~440k across 182 modules. - One shared crate of serde types (artisan-api); Forge as forge-store (rusqlite, one writer, 10 tables), forge-engines (Claude, Codex, OpenCode, ACP for Grok and Cursor), forge-runs and forge-http (stateless HTTPS + SSE with one global seq, mutual-TLS keys and pairing); `ae` as the CLI, installer and Forge host. - The Editor in section crates (core, sidebar, composer, conversation, inspector, settings, marketplace, ui), the transcript a pure fold of items. - Deleted: Cap'n Proto protocol and transport, the old backend, database, domain, migrations, rotating-secret auth, the leases/fences/custody/ receipts machinery and the dead policy modules. - Two build profiles: Debug (deps optimised, line tables) and Release (fat LTO, one codegen unit, abort, stripped). - `ae forge import` brings an old Forge's threads across. Known failing tests: editor-conversation's scrolling_up_through_long_turns_never_jumps (8 px jump) and editor-ui's double_click_drag_extends_by_whole_words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the codebase with the radical reform (see
RADICAL_REFORM.mdfor the why,ARCHITECTURE.mdfor the shape): ~100k lines in 17 crates instead of ~440k across 182 modules.artisan-apiserde types;forge-store(rusqlite, one writer, 10 tables),forge-engines(Claude, Codex, OpenCode, ACP),forge-runs,forge-http(stateless HTTPS + SSE, global seq, mutual-TLS keys).ae: CLI, installer and Forge host;ae forge importbrings an old Forge's threads across.Clippy passes over the workspace. Known failing tests:
editor-conversationscrolling_up_through_long_turns_never_jumps(8 px jump) andeditor-uidouble_click_drag_extends_by_whole_words.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Replaces the codebase with the radical reform: ~100k lines in 17 crates instead of ~440k across 182 modules, per
RADICAL_REFORM.mdandARCHITECTURE.md.Key changes
forge-store(rusqlite, one writer, 10 tables),forge-engines(Claude, Codex, OpenCode, ACP),forge-runs, andforge-http(stateless HTTPS + SSE, mutual-TLS keys, pairing).aeis the new CLI, installer, and Forge host;ae forge importmigrates threads from an old Forge.Known failing tests:
editor-conversationscrolling_up_through_long_turns_never_jumps(8 px jump) andeditor-uidouble_click_drag_extends_by_whole_words.Written for commit a290f31. Summary will update on new commits.