Repository navigation
test: wait for the abort fixture Effect to start - #126
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abort conformance test clicked before the pending Effect's fiber had started, so an early interrupt skipped
onInterruptand the test timed out (seen in release run 39104049541; nothing was published). The fixture now recordsstartedand the test waits for it before discarding the block.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a race condition in the abort conformance test that caused it to time out.
The test discarded the block before the pending Effect's fiber had started, so an early interrupt skipped
onInterrupt. The fixture now records astartedevent before entering the pending effect, and the test waits for that event before discarding the block.Written for commit c743f69. Summary will update on new commits.