Repository navigation
fix: SER 5.0.1 - #128
Merged
Merged
fix: SER 5.0.1#128
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9240930)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
svelte-effect-runtimeentrypoint re-exportseffectfrom the compiler chunk, andcompiler/sveltekit-remote-bridge.tsimportednode:fs/promisesat the top level.vite devserves packages to the browser unbundled, so any page that loaded the client runtime threwModule "node:fs/promises" has been externalized for browser compatibility. The import is now lazy, the same way the compiler already loads its other Node-only modules. Production builds tree-shook it away, so they were not affected.node:specifier.test:conformance:browserruns every Playwright scenario against production servers first, then withCONFORMANCE_SERVER_MODE=developmentagainstvite dev. Native SvelteKit stays the oracle in both modes. The consumer, minimum-kit and broad lanes all use it, and dev results go to.dist/conformance/development, which CI now also uploads as evidence.gracefulShutdown), so portless can stopvite dev. Playwright's default hard kill left those servers running.docs/ser-5.0.1.Verification
node:fs/promisesinchunks/compiler-*.js.corepack pnpm run test: 64 files, 842 tests pass.test:conformance:browserpasses on kit-3-primary in both modes (16 + 16 scenarios).test:conformance:minimum-kitpasses on SvelteKit 2.69.0 in both modes.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the 5.0.0 browser crash in
vite devwhere the rootsvelte-effect-runtimeentrypoint re-exportedeffectfrom the compiler chunk, which eagerly importednode:fs/promisesat the top level. Any page that loaded the client runtime threwModule "node:fs/promises" has been externalized for browser compatibility; production builds were unaffected because tree-shaking removed the import. It is now lazy, matching how the compiler loads its other Node-only modules. All four packages are bumped to 5.0.1.Testing
vite dev(CONFORMANCE_SERVER_MODE=development), with development evidence written to.dist/conformance/development.node:specifier.Written for commit ad11bd6. Summary will update on new commits.