Repository navigation
test: wait for live status to settle after reconnect - #129
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 5.0.1 candidate dry-run (run 39236003027) failed
live-ssr-sharing-update-and-reconnectin the new development lane. SER reportedConnectingwhile native reportedOpen.Live.statussamples its resource every 250 ms. Native readsresource.connectedstraight from the template. So after a reconnect, SER's status can trail the first new value by up to one sample. The scenario already waits forOpenbefore its initial reads. It now does the same before the final read after the reconnect. Both targets must still reach the same status.Verification
Live queriesscenario with--repeat-each 5: passes in development and production.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the live reconnect test so it waits for both targets to report
Openstatus after reconnect before asserting the final state.Live.statussamples its resource every 250 ms, so after reconnecting, the status can trail the first new value by up to one sample. The test now waits forOpenon both left and right clients before the final reads, aligning with the initial wait and preventing flaky failures when SER still reportsConnecting.Written for commit 85c5add. Summary will update on new commits.