[AS-4428] Adding event to track list privacy#485
Open
daytavares wants to merge 2 commits into
Open
Conversation
starsirius
reviewed
Mar 21, 2024
| /** | ||
| * User clicks on the toggle to edit artworks list privacy | ||
| * | ||
| * This schema describes events sent to Segment from [[editedArtworkListPrivacy]] |
Member
There was a problem hiding this comment.
@daytavares The current design requires clicking the "Save Changes" button to save the list privacy update. It means:
- When collector toggles the list privacy for individual list, nothing is really saved, until clicking the "Save Changes" button. And it's possible that collector can toggle the privacy, dismiss the modal, and does not save the changes.
- When clicking "Save Changes", we'll update the list privacy for all lists in a batch.
So I want to double check that
- The event would only be sent when collector clicks "Save Changes", and would not be sent when collector toggles the privacy for individual list.
- We'll fire x number of events when collector saves the changes, with x being the total number of lists.
- I wonder if it's better to just fire 1 event, with all the list privacy value in an array or something.
Let me know if I can pair and clarify things together!
Contributor
Author
|
@starsirius can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: TYPE
This PR resolves [AS-4428]
Description
PR Checklist (tick all before merging)
index.tsclickandtap(platform is inferred by the DB storing events)