Skip to content

feat: add one-tap auth trigger #trivial#694

Merged
brainbicycle merged 2 commits into
mainfrom
brian/one-tap-analytics
May 18, 2026
Merged

feat: add one-tap auth trigger #trivial#694
brainbicycle merged 2 commits into
mainfrom
brian/one-tap-analytics

Conversation

@brainbicycle
Copy link
Copy Markdown
Contributor

@brainbicycle brainbicycle commented May 18, 2026

The type of this PR is: Feature

This PR resolves DI-291

Description

  • adds one-tap as an AuthTrigger to differentiate from regular google sign in
  • adds context_page_path in auth events to capture page auth started on

https://artsy.slack.com/archives/C05EEBNEF71/p1778881199224469?thread_ts=1778874112.044779&cid=C05EEBNEF71

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events) - maybe?

@brainbicycle brainbicycle self-assigned this May 18, 2026
@artsyit artsyit added the Version: Minor A deploy for new features label May 18, 2026
@xander-pero
Copy link
Copy Markdown
Contributor

xander-pero commented May 18, 2026

AFAIK context_page_path is actually something we already get on all our events based on the default web set up. I'm not sure how this works on the backend, but I see this firing within all the payloads for track events and is also present on the table. So just the AuthTrigger change is necessary!
Screenshot 2026-05-18 at 2 40 59 PM

Screenshot 2026-05-18 at 2 36 20 PM

@brainbicycle brainbicycle changed the title feat: add one-tap auth trigger and context page path for capturing auth path #trivial feat: add one-tap auth trigger #trivial May 18, 2026
@brainbicycle brainbicycle merged commit e420a4f into main May 18, 2026
11 checks passed
@brainbicycle brainbicycle deleted the brian/one-tap-analytics branch May 18, 2026 19:14
@artsyit
Copy link
Copy Markdown
Collaborator

artsyit commented May 18, 2026

🚀 PR was released in v4.355.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Version: Minor A deploy for new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants