fix(filterselect): handle nullish entries in selecteditems#1515
Merged
fix(filterselect): handle nullish entries in selecteditems#1515
Conversation
Member
Author
|
It's worth noting: I'll fix this in Force as well. The type here was correct, there's a type assertion that causes the issue on Forces side. We just can't really trust the consumers though, so. |
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can see this in production in some instances. I'm not sure how you can into this state naturally; as the filter aggregations should just not show up. But URLs accessed directly can reproduce it. (Currently: https://www.artsy.net/collect?location_cities%5B0%5D=Tel%20Aviv-Yafo%2C%20Israel&acquireable=true&offerable=true)
cc @artsy/diamond-devs