[SECURITY] Command Injection in HandleAPILogsStreamGET via container name#100
[SECURITY] Command Injection in HandleAPILogsStreamGET via container name#100arumes31 wants to merge 4 commits into
Conversation
…ocker commands Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ocker commands - Strengthened ContainerNameRegex to prevent names starting with hyphens. - Added '--' separator to all 'docker logs' and 'docker restart' commands to prevent argument injection. - Switched to exec.CommandContext with appropriate timeouts and contexts in handlers. - Improved security logging by recording the actual username when a container name is blocked. - Restored correct go.mod and go.sum for CI compatibility. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
- Strengthened ContainerNameRegex to prevent names starting with hyphens. - Added '--' separator to all 'docker logs' and 'docker restart' commands. - Switched to exec.CommandContext with appropriate timeouts and contexts. - Updated security logging to record the actual username. - Added G702 to #nosec pragmas where input is strictly validated. - Restored correct go.mod and go.sum for CI. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
- Strengthened ContainerNameRegex to prevent names starting with hyphens. - Added '--' separator to all 'docker logs' and 'docker restart' commands. - Switched to exec.CommandContext with appropriate timeouts and contexts. - Updated security logging to record the actual username. - Added G702 to #nosec pragmas where input is strictly validated. - Bumped go version to 1.26.4 in go.mod to address GO-2026-5037 and GO-2026-5039. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
Closing as a duplicate. This task is superseded by the newer #113, which takes the stronger approach (adds the |
Understood. Acknowledging that this work is now considered a duplicate of #113. Stopping work on this task as reviews are being consolidated there. |
This PR fixes a potential command injection vulnerability in the APILogsStream endpoint and hardens several other Docker-related commands.
Key changes:
PR created automatically by Jules for task 8937148136502451973 started by @arumes31