Skip to content

[SECURITY] Command Injection in HandleAPILogsStreamGET via container name#100

Closed
arumes31 wants to merge 4 commits into
mainfrom
fix/command-injection-logs-stream-8937148136502451973
Closed

[SECURITY] Command Injection in HandleAPILogsStreamGET via container name#100
arumes31 wants to merge 4 commits into
mainfrom
fix/command-injection-logs-stream-8937148136502451973

Conversation

@arumes31
Copy link
Copy Markdown
Owner

@arumes31 arumes31 commented Jun 2, 2026

This PR fixes a potential command injection vulnerability in the APILogsStream endpoint and hardens several other Docker-related commands.

Key changes:

  • Updated ContainerNameRegex to prohibit names starting with a hyphen.
  • Added the '--' argument separator to all 'docker logs' and 'docker restart' command executions to prevent argument injection.
  • Enforced use of exec.CommandContext with 30s timeouts or request contexts to avoid orphaned processes.
  • Updated security logs in HandleAPILogsStreamGET to record the specific username from the session instead of a hardcoded 'System' user.

PR created automatically by Jules for task 8937148136502451973 started by @arumes31

…ocker commands

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 930f2fb9-9e27-4db4-bd3e-08fb1ec6f3a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/command-injection-logs-stream-8937148136502451973

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

google-labs-jules Bot and others added 3 commits June 2, 2026 23:20
…ocker commands

- Strengthened ContainerNameRegex to prevent names starting with hyphens.
- Added '--' separator to all 'docker logs' and 'docker restart' commands to prevent argument injection.
- Switched to exec.CommandContext with appropriate timeouts and contexts in handlers.
- Improved security logging by recording the actual username when a container name is blocked.
- Restored correct go.mod and go.sum for CI compatibility.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
- Strengthened ContainerNameRegex to prevent names starting with hyphens.
- Added '--' separator to all 'docker logs' and 'docker restart' commands.
- Switched to exec.CommandContext with appropriate timeouts and contexts.
- Updated security logging to record the actual username.
- Added G702 to #nosec pragmas where input is strictly validated.
- Restored correct go.mod and go.sum for CI.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
- Strengthened ContainerNameRegex to prevent names starting with hyphens.
- Added '--' separator to all 'docker logs' and 'docker restart' commands.
- Switched to exec.CommandContext with appropriate timeouts and contexts.
- Updated security logging to record the actual username.
- Added G702 to #nosec pragmas where input is strictly validated.
- Bumped go version to 1.26.4 in go.mod to address GO-2026-5037 and GO-2026-5039.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@arumes31
Copy link
Copy Markdown
Owner Author

arumes31 commented Jun 4, 2026

Closing as a duplicate. This task is superseded by the newer #113, which takes the stronger approach (adds the -- end-of-options separator to the docker command and a hyphen-prefix test case). Consolidating review there.

@arumes31 arumes31 closed this Jun 4, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Closing as a duplicate. This task is superseded by the newer #113, which takes the stronger approach (adds the -- end-of-options separator to the docker command and a hyphen-prefix test case). Consolidating review there.

Understood. Acknowledging that this work is now considered a duplicate of #113. Stopping work on this task as reviews are being consolidated there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant