Skip to content

[FIX] Extract monitoring logic in monitorService#118

Draft
arumes31 wants to merge 1 commit into
mainfrom
extract-monitoring-logic-13536251921273154381
Draft

[FIX] Extract monitoring logic in monitorService#118
arumes31 wants to merge 1 commit into
mainfrom
extract-monitoring-logic-13536251921273154381

Conversation

@arumes31
Copy link
Copy Markdown
Owner

@arumes31 arumes31 commented Jun 4, 2026

This PR refactors the monitorService function in internal/monitor/monitor.go to improve maintainability and readability by extracting its core logic into modular helper functions:

  • getLatestServiceConfig: Handles re-loading the service configuration from disk, allowing the monitor to react to changes (like pausing a service). It now uses index-based access to avoid returning the address of a loop variable.
  • calculateGracePeriod: Centralizes the logic for determining if a service is eligible for restart based on its grace period.
  • runMonitoringCycle: Encapsulates one iteration of the monitoring check, including status updates and failure handling.

Additional changes:

  • Simplified the main loop in monitorService.
  • Added a safety check to ensure the monitoring interval is at least 60 seconds if not specified or invalid.
  • Re-added the "Paused" status update when a service is paused, ensuring UI consistency.
  • Added comprehensive unit tests for calculateGracePeriod in internal/monitor/monitor_test.go.

These changes make the monitoring logic easier to test and reason about without altering the intended behavior of the system.


PR created automatically by Jules for task 13536251921273154381 started by @arumes31

…ions.

- Extracted getLatestServiceConfig for retrieving the latest service configuration.
- Extracted calculateGracePeriod for computing restart eligibility.
- Extracted runMonitoringCycle for encapsulating the core monitoring loop logic.
- Simplified monitorService and added a safety check for the interval.
- Re-added Paused status update in monitorService to maintain original behavior.
- Fixed getLatestServiceConfig to avoid returning address of loop variable.
- Added unit tests for calculateGracePeriod in internal/monitor/monitor_test.go.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b8919d7d-b9d3-4453-b785-c7e0b52d83ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch extract-monitoring-logic-13536251921273154381

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant