Complete audit-mixin-auto-population: groups 3 & 4 - #296
Merged
Merged
Conversation
Budget (group 3): test proves update_budget's previously-stale updated_by is now kept fresh by the automatic listener, not manual CRUD code. Users (group 4): regression tests confirm BugReportModel and DonorGranteeModel now get created_by/updated_by populated for free through their real routes/JWT chain, with no CRUD changes needed. Also carries along the updated OpenSpec workflow conventions doc (sub-issues, branch naming) and config.yaml, plus two freshly staged proposals (budget-fix-295, frontend-fix-294) queued for later work. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297, Closes #298
Summary
updated_bybug is fixed —update_budgetnever setsupdated_byitself, so the passing test demonstrates the automatic SQLAlchemy listener (from groups 1/2) is what now keeps it fresh across edits.BugReportModelandDonorGranteeModelboth useAuditMixinbut their crud functions never setcreated_by/updated_by. Addedservices/users/tests/test_audit_trail_routes.py, which drives both models through their real routes with a real JWT (notmake_client'sget_validated_useroverride, which would bypass the contextvar-setting code under test), confirming both columns now populate automatically with zero CRUD changes.docs/development/WORKFLOW.md+openspec/config.yaml) and two new unimplemented proposals (budget-fix-295-category-cascade-delete-fix,frontend-fix-294-budget-delete-confirm-click) queued for later work.Test plan
services/budgetsuite: 370 passed (369 + 1 new)services/userssuite: 196 passed (194 + 2 new)sharedsuite: 117 passed, 1 pre-existing unrelated worktree-scanning failure🤖 Generated with Claude Code