audit-mixin-rollout-tier4: ai/budget/users created_by/updated_by - #311
Merged
Merged
Conversation
…pdated_by Adds created_at/updated_at/created_by/updated_by to AIProvider, AIProviderModel, DonorTemplateModel, CustomerModel, and UserModel. CustomerModel/UserModel FK created_by/updated_by to users.id via a new AuditMixin.__audit_actor_table__ option (declared_attr-based), replacing hand-copied FK column overrides. migration_helpers.drop_audit_columns now discovers its FK constraints by inspection instead of a duplicated actor_table kwarg, so upgrade/downgrade can't drift out of sync. Also dedupes the budget tests' JWT-builder helper into conftest.py, removes a redundant `id` override on the ai_provider models, and fixes two tier4 tests that asserted against actor UUIDs never persisted to the DB. Also adds proposal docs for three follow-on changes surfaced along the way: budget-fix-money-integrity, shared-feat-138-status-history, and users-fix-auth-claims-hardening. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
created_at/updated_at/created_by/updated_bytoAIProvider,AIProviderModel,DonorTemplateModel,CustomerModel, andUserModel(closes groups 1–3 of audit-mixin-rollout-tier4, Issues audit-mixin-rollout-tier4: ai service catalog models (group 1) #308/audit-mixin-rollout-tier4: budget service DonorTemplateModel (group 2) #309/audit-mixin-rollout-tier4: users service CustomerModel and UserModel (group 3) #310).CustomerModel/UserModelFKcreated_by/updated_bytousers.idvia a newAuditMixin.__audit_actor_table__option (built withdeclared_attr), replacing hand-copied FK column overrides duplicated across both models.migration_helpers.drop_audit_columnsnow discovers its FK constraints via inspection instead of taking a duplicatedactor_tablekwarg, soupgrade()/downgrade()can't drift out of sync.conftest.py, and removed a redundantidoverride on the ai_provider models.budget-fix-money-integrity,shared-feat-138-status-history,users-fix-auth-claims-hardening(no code changes, planning only).Test plan
services/aitest suite: 136 passedservices/budgettest suite: 374 passedservices/userstest suite: 202 passedservices/chattest suite: 98 passed (unaffected, sanity check on sharedAuditMixinchange)🤖 Generated with Claude Code
closes: #308 , #309 , #310