Add audit-mixin coverage guard tests (auto-discovery + shared helper) - #312
Merged
Merged
Conversation
Auto-discovers every module under app/models/ via pkgutil instead of relying on __init__.py's explicit imports, so a model that forgets to be wired in can no longer silently skip the coverage check. Shared assertion logic now lives in shared/tests/audit_mixin_coverage.py instead of being duplicated across all four services. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_every_model_inherits_audit_mixinto ai/budget/chat/users, completing task group 1 of theaudit-mixin-coverage-guardOpenSpec change.app/models/viapkgutilinstead of relying on__init__.py's explicit imports, so a model that forgets to be wired into__init__.pycan no longer silently skip the check.shared/tests/audit_mixin_coverage.py::assert_full_audit_mixin_coverage()instead of being duplicated four times.Test plan
test_audit_mixin_coverage.pypass in isolationservices/ai/app/models/(not imported by__init__.py) and confirmed the guard fails as expected, then removed itblack/flake8/mypyclean via pre-push hook🤖 Generated with Claude Code