feat(export): Sheet 2 — Budget vs. Report Dashboard - #336
Merged
Merged
Conversation
…nor-currency-first layout Refactors Sheet 1 into an OriginalBudgetSheet(_SheetWriter) subclass and adds DashboardSheet with a funding ledger, report summary, and per-line detail section blending real per-allocation conversion rates with the estimated rate for any unsatisfied remainder (flagged with estimate styling). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OriginalBudgetSheet(_SheetWriter)subclass and introduces a shared_SheetWriterbase for cell-writing helpers (pure refactor, no output change to Sheet 1).excel_export_crud.pywith a per-budget-line rollup query joiningbudget_lines→report_lines, and a converted-expense calculation blending real per-allocation conversion rates with the estimated rate for any unsatisfied remainder (flagged with estimate styling when a remainder exists).DashboardSheet(Sheet 2): donor-currency-first layout with a funding ledger (receipts + conversions), a report summary, and per-line/category-subtotal detail rows — revised against a hand-edited reference workbook per design.md Decision 13.Test plan
pytest services/budget/tests/test_excel_export_service.py services/budget/tests/test_excel_export_crud.py— all passingblack --check,mypy,flake8clean (pre-push hooks passed)_SheetWriterrefactor (existing Sheet 1 tests pass unchanged)Closes #318
🤖 Generated with Claude Code