fix(budget): cascade-delete orphaned categories when deleting a budget - #377
Merged
arutsh merged 3 commits intoOct 1, 2026
Merged
Conversation
BudgetModel.categories now uses cascade="all, delete-orphan" with passive_deletes=True. Previously, deleting a budget whose category had outlived its lines nulled out budget_id and failed with an IntegrityError (400). Adds real-DB tests for both the unloaded and the already-loaded categories cases, and updates the design/tasks for the change. Refs #346 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
quay.io/minio/minio now requires auth and minio/minio is gone from Docker Hub, so the E2E workflow failed at image pull on every branch. Switch the local and dev stacks to the pinned community build of the same server, and fold the swap into the 295 change's proposal, design and tasks. Refs #346 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
arutsh
deleted the
Budget/fix/Issue-346/category-cascade-delete-fix-group1
branch
October 1, 2026 15:34
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BudgetModel.categories now uses cascade="all, delete-orphan" with passive_deletes=True. Previously, deleting a budget whose category had outlived its lines nulled out budget_id and failed with an IntegrityError (400).
Adds real-DB tests for both the unloaded and the already-loaded categories cases, and updates the design/tasks for the change.
Refs #346