Repository navigation
fix(budget): cascade-delete budget lines when deleting a budget - #379
Merged
arutsh merged 1 commit intoOct 1, 2026
Merged
Conversation
BudgetModel.lines now uses cascade="all, delete-orphan" with passive_deletes=True, and budget_lines.budget_id gets ON DELETE CASCADE (migration 000021). Previously the ORM nulled budget_id on delete, violating NOT NULL and surfacing as a 400. Budgets whose lines have report lines still fail with 400. Closes #378 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arutsh
deleted the
Budget/fix/Issue-378/budget-delete-with-lines-cascade
branch
October 10, 2026 09:00
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BudgetModel.linesnow usescascade="all, delete-orphan"+passive_deletes=TrueON DELETE CASCADEtobudget_lines.budget_idShould fix
money-precision.spec.ts:47andauth-budget-crud.spec.ts:91in E2E.Closes #378
🤖 Generated with Claude Code