🔒 fix: mask short API keys in terminal output#19
Conversation
Consolidated and improved masking logic for configuration values. - Centralized masking in `_mask_value` helper function. - Ensure any key containing 'api-key' is masked. - Short API keys (<= 8 chars) are now fully masked with '********'. - Long API keys (> 8 chars) retain the prefix/suffix masking. - Masking check is now case-insensitive. This fixes a vulnerability where short API keys were exposed in terminal output. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The vulnerability fixed
The configuration management CLI (
gemstack config) had a logic error where API keys were only masked if they were longer than 8 characters. API keys with 8 or fewer characters were displayed in full plain text in the terminal duringset,get, andlistoperations.Users with short API keys would have their credentials exposed in terminal history, logs, or to shoulder-surfers. This could lead to unauthorized access to their AI service accounts and potential cost/data risks.
🛡️ Solution: How the fix addresses the vulnerability
The fix centralizes the masking logic into a single
_mask_valuehelper function. This function:"api-key".********).config set,config get, andconfig list.PR created automatically by Jules for task 947239730423495154 started by @arvarik