Skip to content

Make database host configurable #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WileESpaghetti wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make database host configurable #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
DATABASE_HOST=mysql
DATABASE_NAME=magento2dockerized
DATABASE_USER=magento
DATABASE_PASSWORD=enAVINa2
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ For more information on how to use docker-compose visit: https://docs.docker.com
The `install` action depends on some parameters such as usernames and passwords. We have put in some default values for you that will work for a quick test:

```
DATABASE_HOST="mysql"
DATABASE_NAME="magento2dockerized"
DATABASE_USER="magento"
DATABASE_PASSWORD="enAVINa2"
Expand Down
8 changes: 7 additions & 1 deletion bin/console
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ fi
. $ENVIRONMENTVARIABLESFILE

# check the environment variables
if [ -z "$DATABASE_HOST" ]; then
echo >&2 "The DATABASE_HOST variable is not set"
exit 1
fi

if [ -z "$DATABASE_NAME" ]; then
echo >&2 "The DATABASE_NAME variable is not set"
exit 1
Expand Down Expand Up @@ -193,6 +198,7 @@ generateSSLCertificate() {
#######################################
# Install Magento
# Globals:
# DATABASE_HOST
# DATABASE_NAME
# DATABASE_USER
# DATABASE_PASSWORD
Expand Down Expand Up @@ -246,7 +252,7 @@ installMagento() {
backendURL="https://${hostname}/${BACKEND_FRONTNAME}"
executeInDocker setup:install --base-url=$baseURLInsecure --base-url-secure=$baseURLSecure --backend-frontname=${BACKEND_FRONTNAME} \
--language=${DEFAULT_LANGUAGE} --currency=${DEFAULT_CURRENCY} --timezone=${DEFAULT_TIMEZONE} \
--db-host=mysql --db-name=${DATABASE_NAME} --db-user=${DATABASE_USER} --db-password=${DATABASE_PASSWORD} \
--db-host=${DATABASE_HOST} --db-name=${DATABASE_NAME} --db-user=${DATABASE_USER} --db-password=${DATABASE_PASSWORD} \
--admin-firstname=${ADMIN_FIRSTNAME} --admin-lastname=${ADMIN_LASTNAME} --admin-email=${ADMIN_EMAIL} --admin-user=${ADMIN_USERNAME} --admin-password=${ADMIN_PASSWORD} \
--cleanup-database --session-save=db

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ services:
ports:
- "8080:80"
environment:
PMA_HOST: "mysql"
PMA_HOST: ${DATABASE_HOST}
PMA_PORT: 3306
networks:
- front
Expand Down