Add Dependencies and Dependents tabs to addon details#434
Merged
Conversation
Draft
b9ddaf0 to
7962858
Compare
7962858 to
fa2f82b
Compare
New Dependencies tab on the addon details view shows per-dependency resolution (installed by an existing addon, satisfied by a manual override, ignored, or unresolved with ranked install suggestions). Each row supports install, ignore, satisfied-by, and revoke actions, with a top-level "Install all" for batch-install of all unresolved suggestions. Suggestions are ranked using the same directory-count / download / date ordering as the global recommender. New Dependents tab lists installed addons that declare this addon as a dependency, derived from the same addon_dependency table. Both tabs become inert (greyed out, "No Dependencies" / "No Dependents" labels) when empty rather than disappearing. Adds the supporting types (AddonRef, Resolution, DepStatus, AddonDependencyView) in service::result and the service methods that back the tabs (get_addon_dependency_view, set_dep_ignored, set_dep_satisfied_by, revoke_dep_override, install_dep_suggestions). Also trigger check_missing_deps directly from handle_addons_changed so the missing-deps sidebar entry clears as soon as the user resolves all missing deps, instead of relying on the installed_addons -> check_missing_deps chain (which only fires after the filesystem walk completes, and never fires at all if install_missing_dependencies hits the unwrap() panic path). handle_addons_changed now kicks off both refreshes in parallel, so guard the auto-navigate to the MissingDeps view against installed_addons.value being None — only the modal auto-pop is deferred until both promises have results; the sidebar entry itself updates correctly.
fa2f82b to
f606e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Dependencies tab on the addon details view shows per-dependency resolution (installed by an existing addon, satisfied by a manual override, ignored, or unresolved with ranked install suggestions). Each row supports install, ignore, satisfied-by, and revoke actions, with a top-level "Install all" for batch-install of all unresolved suggestions. Suggestions are ranked using the same directory-count / download / date ordering as the global recommender.
New Dependents tab lists installed addons that declare this addon as a dependency, derived from the same
addon_dependencytable. Both tabs become inert (greyed out, "No Dependencies" / "No Dependents" labels) when empty rather than disappearing.Adds the supporting types (
AddonRef,Resolution,DepStatus,AddonDependencyView) inservice::resultand the service methods that back the tabs (get_addon_dependency_view,set_dep_ignored,set_dep_satisfied_by,revoke_dep_override,install_dep_suggestions).Also trigger
check_missing_depsdirectly fromhandle_addons_changedso the missing-deps sidebar entry clears as soon as the user resolves all missing deps, instead of relying on theinstalled_addons -> check_missing_depschain (which only fires after the filesystem walk completes, and never fires at all ifinstall_missing_dependencieshits theunwrap()panic path).handle_addons_changednow kicks off both refreshes in parallel, so the auto-navigate to the MissingDeps view is guarded againstinstalled_addons.valuebeing None — only the modal auto-pop is deferred until both promises have results; the sidebar entry itself updates correctly.Related