Fix harvest map data fetch & option saves#438
Merged
Conversation
HarvestMapData contains binary data that needs to be written as such, the downloader was trying to transform the data into UTF-8 and inserting UTF-8 replacement characters. Update the file writes so that they're atomic (so the game never reads a partially written file). Fetches now also stream to the tempfile rather than slurping to memory. The checkbox options were not always persisting on toggle, they now persist immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HarvestMapData contains binary data that needs to be written as such, the downloader was trying to transform the data into UTF-8 and inserting UTF-8 replacement characters.
The checkbox options were not always persisting on toggle, they now persist immediately.