Fix catalog refresh hitting SQLite bound-parameter limit#443
Merged
Conversation
`update()` was issuing `insert_many` for the entire ESOUI catalog (~5000 addons * 10 columns) as a single statement, exceeding SQLITE_MAX_VARIABLE_NUMBER (32766). The failure left the addon list empty and the UI displayed "No addons installed!". Wrap update() and update_categories() in a transaction and switch from multi-row `insert_many` to per-row `Entity::insert()` reused inside the transaction. sqlx caches the prepared statement by SQL text, so each row reuses the same plan. The transaction also gives atomicity: a partial failure no longer leaves the catalog in a half-written state. is_in filters still bind one parameter per ID, so the three delete statements are chunked by SQLITE_MAX_VARS for safety (no chunking actually triggers at the current catalog size).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update()was issuinginsert_manyfor the entire ESOUI catalog (~5000 addons * 10 columns) as a single statement, exceeding SQLITE_MAX_VARIABLE_NUMBER (32766). The failure left the addon list empty and the UI displayed "No addons installed!".Wrap update() and update_categories() in a transaction and switch from multi-row
insert_manyto per-rowEntity::insert()reused inside the transaction. sqlx caches the prepared statement by SQL text, so each row reuses the same plan. The transaction also gives atomicity: a partial failure no longer leaves the catalog in a half-written state.is_in filters still bind one parameter per ID, so the three delete statements are chunked by SQLITE_MAX_VARS for safety (no chunking actually triggers at the current catalog size).