fix: resolve misleading empty state when searching in TaskLibrary#1386
Open
Abhishek2005-ard wants to merge 18 commits into
Open
fix: resolve misleading empty state when searching in TaskLibrary#1386Abhishek2005-ard wants to merge 18 commits into
Abhishek2005-ard wants to merge 18 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the user experience in the
TaskLibrary.jsxcomponent by resolving an edge case with the search functionality.Previously, searching for a task that yielded zero results would trigger the generic
<EmptyState />component. Since theEmptyStatecomponent is designed to prompt users to add their first task when their entire library is empty, displaying it during a failed search was confusing and made it look like the user's tasks were deleted.Changes Made
tasks.length === 0), it renders the standardEmptyStatecomponent.Testing
close #1383