Allow rap2hpoutre/laravel-log-viewer ^3.0 (Laravel 13 support + RCE fix)#27
Open
steffenschmidt wants to merge 1 commit into
Open
Allow rap2hpoutre/laravel-log-viewer ^3.0 (Laravel 13 support + RCE fix)#27steffenschmidt wants to merge 1 commit into
steffenschmidt wants to merge 1 commit into
Conversation
Widen the log-viewer constraint from `^2.3.0` to `^2.3 || ^3.0`. - Unblocks Laravel 13: log-viewer v2.x caps at Laravel 12, so Logbook currently forces Statamic 6 users to stay on Laravel 12 - Pulls in the v3.1.0 security fix for insecure deserialization (RCE) and path traversal via query parameters (rap2hpoutre/laravel-log-viewer#320) - No code changes required: Logbook only uses setFile(), pathToLogFile(), all(), getFiles() and getFileName(), none of which changed between v2.5.0 and v3.1.0
Owner
|
Thanks @steffenschmidt, will try and give this a test to ensure no breaking changes in the next few weeks when I find some time. Appreciate it 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
Widens the
rap2hpoutre/laravel-log-viewerconstraint from^2.3.0to^2.3 || ^3.0so Logbook can be installed alongside log-viewer v3.x.Why
illuminate/support ^6|...|^12). Statamic 6 supports Laravel 12 and 13, but the current^2.3.0pin forces Logbook users to stay on 12.Why this is safe
LogbookControlleronly usessetFile(),pathToLogFile(),all(),getFiles()andgetFileName()fromLaravelLogViewer. None of these changed between v2.5.0 and v3.1.0 — the diff is just composer constraints, the security fix, and a small refactor in two files.Testing
Running this on a Statamic 6.19 / Laravel 13 project. Logbook utility loads, lists log files, displays and deletes them as expected. Verified both ways:
v3.1.0 as v2.5.0) before this change