Repository navigation
fix(i18n): translate remaining hardcoded screens - #55
Merged
Merged
Conversation
Complete i18n migration for all remaining hardcoded user-facing strings in root src/ (follow-up to #47, #48-#51, #54). Move strings to translation keys and fill in all 9 locales (de, en, es, fr, it, ja, ko, nl, pt). Screens covered: - ChoresView: all modals, buttons, labels, empty states - Leaderboard: titles, period toggles, chore counts - StreakBadge: tooltip and labels - MusicView: empty state, player selection, playback controls - NowPlayingBar: all aria-labels - GroceryView: list selector, add/delete, item states - OnboardingView: all steps, auth methods, error messages - CardPickerModal: title and empty state - ViewNameModal: labels and buttons - Registry: default entities placeholder Also fixed defaultConfig for ha-entities-list card to use translation key for placeholder instead of hardcoded "Entities" default title. All changes mirrored to beacon/src/. TypeScript types enforce completeness across all locales. German translations vouched for by maintainer; others machine-generated but consistent with #54 terminology (To-dos vs Chores). Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Aaron Sachs <asachs01@users.noreply.github.com>
CardConfigField type doesn't support placeholderKey property. Changed defaultConfig title to empty string instead of hardcoded "Entities". Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Aaron Sachs <asachs01@users.noreply.github.com>
asachs01
marked this pull request as ready for review
October 17, 2026 14:33
|
🎉 This PR is included in version 1.39.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #47, #48-#51, and #54. Completes the i18n migration by translating all remaining hardcoded user-facing strings in root
src/.Screens covered
ha-entities-listcard to use translation key for placeholderChanges
beacon/src/scripts/check-beacon-sync.shpassesFiles modified
Root and beacon directories: