Allow any 1.* version for angular#199
Open
CaporalDead wants to merge 4 commits intoasafdav:masterfrom
Open
Conversation
|
@CaporalDead Your propose solution supports only versions in the range > 1.0 and < 1.1. You have to change the operator from ~ to ^. Convince yourself here: https://semver.npmjs.com/ . Please check my pull-request: digitaleo#1 |
Author
|
@wildgarden true, we changed it on our private repo and I did not reflect this change on the public github fork we have. I'll fix it tomorrow. Thx for your feedback :). |
Fix operator to match any version > 1.0
Author
|
@wildgarden updated with your proposal |
|
@CaporalDead Thanks, for your fast response. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You shouldn't force users to pull only latest major version of angular and dep.
~1prevent the use of angular 1.5.*.Change to
~1.0