Conversation
asb2m10
left a comment
asb2m10
left a comment
There was a problem hiding this comment.
Thanks for you PR ! Next time each features should be on its own branch so one feature might not block other features upon PR approval.
| return false; | ||
| } | ||
|
|
||
| activePgm = currentIdx; |
There was a problem hiding this comment.
Yes, this is a good idea. I've checked with other synths and browsing presets with arrows keys does change the preset. We should do the same.
Source/CartManager.cpp
Outdated
| void CartManager::fileDoubleClicked(const File& file) { | ||
| if ( file.isDirectory() ) | ||
| return; | ||
| int rc = AlertWindow::showOkCancelBox(AlertWindow::QuestionIcon, "Load Cartridge", |
There was a problem hiding this comment.
Not too sure if we should confirm with the user when he wants to load a cartridge to the synth. Personally I would be overwhelmed each time I load a cartridge from the browser. Usually a CTRL-Z from the DAW should revert the load. I will test that.
The confirmation should be applicable when a user wants to insert a program into an external cartridge that could possibly change user file. To me this is were we should confirm this operation.
Source/CartManager.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void CartManager::programAutoCopied(ProgramListBox *source, int pos) { |
There was a problem hiding this comment.
Interesting idea, but I would rather see a CTRL-C that copies the program and CTRL-V that paste the program from the clipboard. Unless the user reads the documentation, I doubt this feature will be used organically.
2 participants
Uh oh!
There was an error while loading. Please reload this page.