ci: verify build and tests#67
Merged
nodece merged 15 commits intoascentstream:branch-as-2.10from Jun 9, 2025
Merged
Conversation
### Motivation - prometheus `simpleclient` has broken api, it makes `pulsar-client-origin` can not well used with other libraries - specify `OpenMetrics` This PR contains metric name broken changes. ### Modifications Bump prometheus client version from 0.5.0 to 0.15.0 ### changes - bump the client version - rename the field prometheus client `UNTYPED` to `UNKNOWN` - `OpenMetrics`'s counter name needs a `_total` suffix ### metrics name broken changes - rename `pulsar_expired_token_count` to `pulsar_expired_token_total` - rename `pulsar_authentication_success_count` to `pulsar_authentication_success_total` - rename `pulsar_authentication_failures_count` to `pulsar_authentication_failures_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_source_received_total_1min` to `pulsar_source_received_1min_total` - rename `pulsar_source_written_total_1min` to `pulsar_source_written_1min_total` - rename `pulsar_source_source_total_1min` to `pulsar_source_source_exceptions_1min_total ` - rename `pulsar_source_system_exceptions_total_1min` to `pulsar_source_system_exceptions_1min_total ` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total ` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_function_received_total_1min` to `pulsar_function_received_1min_total` - rename `pulsar_function_user_exceptions_total_1min` to `pulsar_function_user_exceptions_1min_total` - rename `pulsar_function_system_exceptions_total_1min` to `pulsar_function_system_exceptions_1min_total` - rename `pulsar_function_processed_successfully_total_1min` to `pulsar_function_processed_successfully_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` - rename `pulsar_sink_received_total_1min` to `pulsar_sink_received_1min_total` - rename `pulsar_sink_written_total_1min` to `pulsar_sink_written_1min_total` - rename `pulsar_sink_sink_exceptions_total_1min` to `pulsar_sink_sink_exceptions_1min_total` - rename `pulsar_sink_system_exceptions_total_1min` to `pulsar_sink_system_exceptions_1min_total` ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-required` As mentioned above, the metrics name has changed (cherry picked from commit c0b4d57) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
### Motivation prometheus client 0.16.0 contains some approvements that we can benefit from. Thanks for @dave2wave @michaeljmarshall the reminder and pointing out. > [ENHANCEMENT] Reduce the number of core threads in HTTPServer from 5 to 1. The HTTPServer will still start up to 5 threads on demand if there are parallel requests, but it will use only 1 thread as long as requests are sequential (prometheus/client_java#786). [ENHANCEMENT] Optimize metric name sanitization: Replace the regular expression with a hard-coded optimized algorithm to improve performance (prometheus/client_java#777). Thanks @fwbrasil See https://github.com/prometheus/client_java/releases ### Modifications Bump prometheus client version from 0.15.0 to 0.16.0 ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` dependency updates, no need doc (cherry picked from commit 948000b) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
branch-as-2.10-0605
branch
7 times, most recently
from
fb01637 to
5472dc7
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
branch-as-2.10-0605
branch
from
5472dc7 to
bdc6844
Compare
…AndCommitForTransaction (apache#17845) * scenario is already covered by PendingAckPersistentTest (cherry picked from commit 5f59f8b)
nodece
force-pushed
the
branch-as-2.10-0605
branch
3 times, most recently
from
65f168f to
c06ee70
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
branch-as-2.10-0605
branch
2 times, most recently
from
0c2d8c9 to
a6f743d
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
branch-as-2.10-0605
branch
from
a6f743d to
df58bc6
Compare
Signed-off-by: tison <wander4096@gmail.com> (cherry picked from commit b969fe5) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: