Skip to content

Improving performance when verifying 1000s of files in one history #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ptrpfn wants to merge 1 commit into from
Closed

Improving performance when verifying 1000s of files in one history #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ascmhl/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,13 @@ def create_for_folder_subcommand(
file_path = os.path.join(folder_path, item_name)
not_found_paths.discard(file_path)
for hash_list in existing_history.hash_lists:
for media_hash in hash_list.media_hashes:
if media_hash.path == existing_history.get_relative_file_path(file_path):
break
if detect_renaming:
# this is quite costly, especially for 1000s of files <- the symptom is that the IO becomes slower and slower due to the fs system access for `get_relative_path``
for media_hash in hash_list.media_hashes:
if media_hash.path == existing_history.get_relative_file_path(file_path):
break
else:
new_paths.add(file_path)
else:
new_paths.add(file_path)
if is_dir:
Expand Down