Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_create.py,test_nested.py,test_hasher.py)Bugs covered
1.
generator.py:75— Class object inserted into hash entries listhash_entries = [MHLHashEntry]creates a list containing the MHLHashEntry class itself as the first element instead of an empty list. This causes the class to be appended as a bogus entry into every media hash created viaappend_multiple_format_file_hashes.2.
history.py:105— TypeError crash in nested history ignore patternslatest_ignore_pattern_from_nested_histories()iterates overhistory.latest_ignore_patterns()which returnsNonewhen a child history has no hash lists or no ignore spec, causingTypeError: 'NoneType' object is not iterable.3.
history.py:370— Early return aborts all reference resolution_resolve_hash_list_references()usesreturninstead ofcontinuewhen a reference path is not found inchild_history_mappings, causing the method to abort processing all remaining references across all hash lists.4.
hasher.py:250— Type assigned instead of dict in AggregateHasherhasher_lookup = Dict[str, str]assigns thetyping.Dicttype object instead of creating an empty dict, crashing withTypeErroron item assignment whenAggregateHasher.__init__is called.Test plan