Repository navigation
ci: add job timeouts, devcontainer prebuild caching, pin runners to ubuntu-24.04 - #79
Merged
Merged
Conversation
…buntu-24.04 Closes #78
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aseguragonzalez
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
timeout-minutesto every job across.github/workflows/*.yml(5 min forlint/format/typecheck/test/docs/pr-title-lint/release jobs, 10 min for the devcontainer
quality job).
.github/workflows/devcontainer-prebuild.yml, which builds and pushes a devcontainercache image to GHCR (
ghcr.io/aseguragonzalez/python-seedwork-devcontainer) whenever.devcontainer/**changes onmain.cacheFromindevcontainer-quality.yml's build step(alongside
push: never, so the quality-gate run never pushes an image itself).runs-on: ubuntu-latesttoruns-on: ubuntu-24.04across all workflows.devcontainers/ci@*anddocker/login-action@*to the repo's GitHub Actionsallowed-actions list (
selected_actions), since the policy only allows an explicitset of non-GitHub-owned actions.
Why
a runner for hours with only the GitHub-wide 6h default as a backstop.
devcontainer-quality.ymlhad no prebuilt cache image, so everyrun rebuilt it from scratch, and every run was in fact failing at startup because
devcontainers/ciwas never added to the repo's actions allowlist.ubuntu-latestis a moving target; pinning toubuntu-24.04keeps the runner imageversion stable and reproducible across runs. This is a manual, one-off pin for
reproducibility — Dependabot does not track or update runner labels.
devcontainers,pip,github-actions) was already complete andneeded no change.
How
timeout-minutes:to each job definition; reusable-workflow-call jobs (uses:)were left untouched since they have no
runs-on.devcontainer-prebuild.ymlworkflow usingdocker/login-action(GHCR login) anddevcontainers/ci(build + push) triggered on pushes tomaintouching.devcontainer/**.actions/permissions/selected-actionsallowlist via the GitHub API toinclude
devcontainers/ci@*anddocker/login-action@*in addition to the existingentries.
runs-on: ubuntu-latestwithruns-on: ubuntu-24.04.How to test
gh pr checks <PR number>— all workflows (CI, PR title lint) pass.main(or manually trigger) to confirmdevcontainer-prebuild.ymlbuilds andpushes the cache image successfully; a subsequent
devcontainer-quality.ymlrun shouldthen be faster thanks to
cacheFrom.Closes #78