fix: ignore stale Esc retractions safely - #19
Merged
Merged
Conversation
- Validate rollback boundaries before interrupting provider turns - Silently restore optimistic composer state when boundaries are unavailable
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Added provider-side validation for rollback boundaries before interrupting a live turn. Unavailable retained boundaries now produce silent failures, restore the optimistic composer state, and avoid surfacing stale Esc retraction errors in the thread feed and work log. Added focused server, provider, web recovery, and session-logic tests.
Why
An Esc retraction could target provider history that was no longer available, leaving the turn marked failed and exposing an error even though the retraction was stale and should be ignored. Validating the boundary first prevents unnecessary interruption, while restoring the pre-Esc composer state keeps the user’s draft intact.
UI Changes
No visible UI changes. Silent stale-retraction failures are intentionally omitted from error surfaces and restore the composer state.
Checklist