Skip to content

fix(web): preserve imported theme colors and contrast - #38

Merged
asfires merged 1 commit into
mainfrom
t3code/improve-imported-theme-colors
Aug 17, 2026
Merged

asfires merged 1 commit into
mainfrom
t3code/improve-imported-theme-colors

Conversation

@asfires

@asfires asfires commented Aug 17, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Preserve imported VS Code theme foreground, status, surface, hover, border, and accent colors when generating T3 palettes.
  • Treat fully transparent theme colors as unset and fall back to visible candidates.
  • Derive readable text and status foregrounds by adjusting lightness while retaining the source hue.
  • Keep surface ramps and borders visually distinct without flattening the imported palette.
  • Expand Open VSX and VS Code theme import coverage with focused regression tests.

Why

Imported themes could lose their visual identity during palette generation: muted text became too bright, surfaces collapsed into the canvas, transparent values erased hover and focus states, and status colors could fall back to unrelated defaults. This update keeps the theme’s original color signals while ensuring the resulting palette remains readable and visually distinct.

UI Changes

No screenshots included; the changes affect generated theme colors and contrast across imported themes rather than a specific layout.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

- Derive surfaces, text, borders, status colors, and accents from VS Code theme signals
- Preserve hue while improving readability and preventing flattened UI states
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 17, 2026
@asfires
asfires merged commit a73b151 into main Aug 17, 2026
6 of 10 checks passed
@asfires
asfires deleted the t3code/improve-imported-theme-colors branch August 17, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant