Clear vectors and row ids on delete#243
Open
marcus-pousette wants to merge 3 commits intoasg017:mainfrom
Open
Conversation
added 3 commits
September 5, 2025 11:03
vlasky
added a commit
to vlasky/sqlite-vec
that referenced
this pull request
Nov 28, 2025
Implements proper cleanup when deleting rows to prevent memory/storage leaks: - vec0Update_Delete_ClearRowid(): Zeros out rowid slot in chunks.rowids blob - vec0Update_Delete_ClearVectors(): Zeros out vector data in all vector_chunks Additional improvements: - Add -undefined dynamic_lookup flag for macOS builds (standard for SQLite extensions) - Add test-snapshots-update Makefile target - Add comprehensive tests to verify delete properly clears bytes - Add .venv to .gitignore Merged from upstream PR asg017#243 by marcus-pousette. Fixes issues asg017#54, asg017#178, asg017#220. Co-Authored-By: Marcus Pousette <marcus.pousette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#220
#178
#54