fix(ci): reference the unused-deps input by its declared name - #2813
Merged
Conversation
The input is declared as `unused-deps` but the job is gated on `inputs.unused_deps`. That property does not exist, so the expression is empty, and the job has been skipped on every run since the feature was added in 2f2015e (2026-03-25) — `mix deps.unlock --check-unused` has never actually run. Visible on any recent run of Ash's own CI: the job reports "skipped" in both matrix legs despite the input defaulting to true. Nearby gates such as `inputs.changelog-lint` use the hyphenated name directly and work, so this is just the one identifier.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unused-depsinput is declared with a hyphen, but the job is gated oninputs.unused_deps:inputs.unused_depsis not a property of theinputscontext, so the expression evaluates to empty, and the job is skipped on every run.It has never run
The typo was present in 2f2015e, the commit that added the feature on 2026-03-25, so
mix deps.unlock --check-unusedhas not executed once in the ~4 months since — for this repository or any downstream one callingash-ci.yml.Visible on a recent
mainrun (30698561054):despite the input defaulting to
true.It went unnoticed because the failure mode is a skipped job rather than a failing one — it still appears in the checks list, greyed out and non-blocking, so it looks present.
The fix
One identifier. Hyphenated names work fine with dot notation in this file —
inputs.changelog-lint,inputs.community-files,inputs.publish-docsandinputs.spark-formatterall do it, andChangelog Lintreports success in the same run — so matching the declared name is all that is needed.Found while setting up CI for
ash_localizeon top of this workflow.