Skip to content

fix(ci): reference the unused-deps input by its declared name - #2813

Merged
zachdaniel merged 1 commit into
mainfrom
fix/unused-deps-input-name
Aug 1, 2026
Merged

fix(ci): reference the unused-deps input by its declared name#2813
zachdaniel merged 1 commit into
mainfrom
fix/unused-deps-input-name

Conversation

@joshprice

Copy link
Copy Markdown
Contributor

The unused-deps input is declared with a hyphen, but the job is gated on inputs.unused_deps:

      unused-deps:            # declared
        type: boolean
        default: true
...
  unused-deps:
    if: ${{inputs.unused_deps}}   # referenced

inputs.unused_deps is not a property of the inputs context, so the expression evaluates to empty, and the job is skipped on every run.

It has never run

The typo was present in 2f2015e, the commit that added the feature on 2026-03-25, so mix deps.unlock --check-unused has not executed once in the ~4 months since — for this repository or any downstream one calling ash-ci.yml.

Visible on a recent main run (30698561054):

skipped  ash-ci (Picosat)   / mix deps.unlock --check-unused
skipped  ash-ci (SimpleSat) / mix deps.unlock --check-unused

despite the input defaulting to true.

It went unnoticed because the failure mode is a skipped job rather than a failing one — it still appears in the checks list, greyed out and non-blocking, so it looks present.

The fix

One identifier. Hyphenated names work fine with dot notation in this file — inputs.changelog-lint, inputs.community-files, inputs.publish-docs and inputs.spark-formatter all do it, and Changelog Lint reports success in the same run — so matching the declared name is all that is needed.

Found while setting up CI for ash_localize on top of this workflow.

The input is declared as `unused-deps` but the job is gated on
`inputs.unused_deps`. That property does not exist, so the expression is empty,
and the job has been skipped on every run since the feature was added in
2f2015e (2026-03-25) — `mix deps.unlock --check-unused` has never actually run.

Visible on any recent run of Ash's own CI: the job reports "skipped" in both
matrix legs despite the input defaulting to true. Nearby gates such as
`inputs.changelog-lint` use the hyphenated name directly and work, so this is
just the one identifier.
@zachdaniel
zachdaniel merged commit 9c31079 into main Aug 1, 2026
43 of 49 checks passed
@zachdaniel

Copy link
Copy Markdown
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants