Update Node.js and pnpm requirements#127
Conversation
- Updated `package.json` engines to require Node.js >= 24 and pnpm >= 10. - Updated `@types/node` to ^24.12.4. - Updated `README.md`, `docs/DEVELOPMENT.md`, and `AGENTS.md` to reflect these requirements. - Updated `package-lock.json` via `npm install`. Co-authored-by: ashcoft <1115854+ashcoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR standardizes the project's development tooling by requiring Node.js 24+, establishing pnpm 10+ as the preferred package manager, and updating all development documentation and installation instructions to reflect these new constraints. ChangesDevelopment Tooling & Engine Constraints
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
README.md (1)
63-65:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd --legacy-peer-deps flag to npm install commands.
All npm install commands should include the
--legacy-peer-depsflag due to peer dependency conflicts in the@mlightcadpackages. This is properly documented in AGENTS.md but missing from these user-facing instructions. Based on learnings, when using npm for frontend dependencies, always use the--legacy-peer-depsflag.📝 Proposed fix
4. Build the frontend assets: ```bash cd cad_viewer - npm install + npm install --legacy-peer-deps npm run build ```# Install dependencies -npm install +npm install --legacy-peer-deps```diff 1. Update the dependency: ```bash - npm update `@mlightcad/cad-viewer` + npm update `@mlightcad/cad-viewer` --legacy-peer-deps ```1. Clear node_modules and reinstall: ```bash rm -rf node_modules - npm install + npm install --legacy-peer-deps ```Also applies to: 106-107, 159-159, 204-204
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 63 - 65, Update all user-facing npm commands in README.md to include the --legacy-peer-deps flag: replace occurrences of the literal command "npm install" with "npm install --legacy-peer-deps" (including the install after "rm -rf node_modules") and change "npm update `@mlightcad/cad-viewer`" to "npm update `@mlightcad/cad-viewer` --legacy-peer-deps" so every instruction using npm for frontend dependencies uses the flag described in AGENTS.md.docs/DEVELOPMENT.md (1)
16-17:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd --legacy-peer-deps flag to npm install command.
The npm install command should include the
--legacy-peer-depsflag due to peer dependency conflicts in the@mlightcadpackages. This is properly documented in AGENTS.md. Based on learnings, when using npm for frontend dependencies, always use the--legacy-peer-depsflag.📝 Proposed fix
3. Install dependencies: ```bash - npm install + npm install --legacy-peer-deps ```🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/DEVELOPMENT.md` around lines 16 - 17, Update the npm install instruction in DEVELOPMENT.md to include the --legacy-peer-deps flag (replace the current "npm install" command with "npm install --legacy-peer-deps") so frontend dependency installation uses legacy peer deps resolution consistent with AGENTS.md and avoids `@mlightcad` peer dependency conflicts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/DEVELOPMENT.md`:
- Around line 16-17: Update the npm install instruction in DEVELOPMENT.md to
include the --legacy-peer-deps flag (replace the current "npm install" command
with "npm install --legacy-peer-deps") so frontend dependency installation uses
legacy peer deps resolution consistent with AGENTS.md and avoids `@mlightcad` peer
dependency conflicts.
In `@README.md`:
- Around line 63-65: Update all user-facing npm commands in README.md to include
the --legacy-peer-deps flag: replace occurrences of the literal command "npm
install" with "npm install --legacy-peer-deps" (including the install after "rm
-rf node_modules") and change "npm update `@mlightcad/cad-viewer`" to "npm update
`@mlightcad/cad-viewer` --legacy-peer-deps" so every instruction using npm for
frontend dependencies uses the flag described in AGENTS.md.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f8f82d05-5919-496b-806a-c2288b9af181
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
AGENTS.mdREADME.mddocs/DEVELOPMENT.mdpackage.json
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
1 participant
This PR updates the project's development prerequisites to align with the requirements for
@mlightcad/cad-viewer.Changes:
engines.nodeto>=24and addedengines.pnpmto>=10.^24.12.4.README.md,docs/DEVELOPMENT.md, andAGENTS.mdto include Node.js 24+ and pnpm 10+ as requirements. Added pnpm usage instructions toAGENTS.md.@types/node.Verified with
npm testandnpm installto ensure package availability and baseline stability.PR created automatically by Jules for task 2659843271348179647 started by @ashcoft
Summary by CodeRabbit
@types/nodedependency to the latest compatible version.