Remove signature verification filter from drafts rendering - #97
Merged
Conversation
Release: merge staging into master
Drafts are authored by the current user and are never signed until they are sent, so signature_valid is always null on them. renderDrafts was filtering on signature_valid !== true whenever hide_unsigned_messages was enabled (the default), which silently hid every saved draft from the drafts page. Mirror the sent-mail rendering path, which already bypasses this filter because that mail is self-authored, and drop the now-unreachable 'no verified drafts' empty state.
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the
hide_unsigned_messagessetting filter from the drafts list rendering logic. This setting is intended to protect against unverified inbound senders and should not apply to user-authored drafts, which are unsigned until sent.Changes
hideUnverifiedfilter that was preventing unsigned drafts from being displayedhide_unsigned_messagessetting does not apply to themDetails
The
hide_unsigned_messagessetting is a security feature designed to filter out emails from unverified external senders. However, user drafts are inherently unsigned until they are sent, making this filter inappropriate for the drafts view. This change ensures drafts are always displayed to the user regardless of signature status.https://claude.ai/code/session_01LrqsXTXYxSkN4ewqfuTqE1