Repository navigation
Conversation
|
Thanks @Bizuayeu for finding the missing 753,692,264-byte shard in the admission estimate, while the existing NVFP4 checkpoint stays at 204,439,103,396 bytes. We're taking this with fixes for 1.1.1. Distinct indexed filenames, including subfolders, are counted once. Review added refusal for missing named files, malformed indexes and allocation/stat failures, so a broken index cannot silently become a smaller flat-folder estimate. Valid no-index folders retain their old counting behavior. This changes admission accounting, not inference. The host and admission-refusal controls cover those cases; complete FP4-Local loading and rank/device checks remain under #1015. Posted by Ash's AI Assistant Synthena |
…s, so shards under tensors/ are no longer left out of the estimate
41dca5c to
694c62a
Compare
|
Rebased onto 1.1.0 ( |
Credit: @Bizuayeu for indexed shard counting and its original fixture. Include mandatory maintainer refusal fixes for broken maps, missing files and allocation errors. Route the named refusal through the maintained family-memory admission owner.
|
Thanks @Bizuayeu. 1.1.1 counts each indexed filename once, including subfolders, and refuses malformed indexes, missing/non-file shards, allocation/stat failures and overflow before loading. Only an absent index or weight map falls back. Your 694c62a rebase retains the original permissive reader; our maintained fail-closed equivalent already covers the required repair. Closing for the shipped accounting scope, with your credit retained. Mixed-format GLM serving remains a separate checkpoint gate. Posted by Ash's AI Assistant Synthena |
What this changes
weightBytes, the estimate that refuses a launch that cannot fit, now counts each file thatmodel.safetensors.index.json's weight map names, once, so shards in a subfolder are no longer left out (#1015). Without an index, or with an index that has no weight map, it counts the folder's own*.safetensorsas before. In 1.1.0 the estimate is called fromnative/cuda_family_memory.zig, which now passes its allocator.nvidia/GLM-5.3-Flash-FP4-Localkeeps one shard intensors/(tensors/native-QB.safetensors).nvidia/Qwen3.8-Flash-Next-FP4-Localkeeps all of its shards there.Receipt
76aafcf2) plus this commit, Zig 0.17.0. Host tests on x86_64 Linux, on an LF tree fromgit archive. The byte counts below are the files' sizes on a GB10.nvidia/GLM-5.3-Flash-FP4-Local@76348ddb: 176,710,148,760 → 177,463,841,024 bytes. The difference, 753,692,264, istensors/native-QB.safetensors.nvidia/GLM-5.3-Flash-NVFP4@da920bb: 204,439,103,396 both ways. All 33 of its files are in the folder.zig build test: 152/152 steps, 2414/2423 tests passed, 9 skipped.zig build test-kernel-contract,test-golden,fuzz-cortheon, thetools/zigunittest (flashnext_batch_serve_test.py) and a plainzig build: succeeded.main).git diff --check: clean.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo. (No inference path changes.)SUMMARYline is in the receipt. (No GPU kernel.)