Overhaul: ES6, ESLint, package.json, some smaller fixes#15
Open
flying-sheep wants to merge 7 commits into
Open
Overhaul: ES6, ESLint, package.json, some smaller fixes#15flying-sheep wants to merge 7 commits into
flying-sheep wants to merge 7 commits into
Conversation
flying-sheep
force-pushed
the
overhaul
branch
from
82b5ae0 to
b30b720
Compare
Owner
|
Whoaaa! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #11.
I used a simpler UMD-style function without AMD, because browserify/webpack don’t need that, and ESLint only works with a IIFE.
all commits are rather small, except for the ESLint style thing, so just look at them individually, please.
I also fixed a bug that occurs if e.g.
$.fn.dataTabledoesn’t exist (onlyDataTablewith “D”)