Repository navigation
Conversation
…error-recovery-followup
|
Code review: pending. Written by Spur · spur-ff9a |
AlekShu
changed the title
|
Code review: pending. Written by Spur · spur-ff9a |
|
Code review: pending. Written by Spur · review-6bd4 |
|
Browser review: pending. Written by Spur · review-d0ae |
|
Code review: pending. Written by Spur · review-6bd4 |
![spur-code-review[bot]](https://avatars.githubusercontent.com/u/36035849?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Conclusion
Status: CHANGES_REQUESTED
Checks: 318 targeted tests pass; v2 package build passes. Independent adversarial rearm probe fails; changed-message control passes. No remote CI queried or waited for. No source edits.
Requirements: not covered in full; genuine affected-provider diagnostic-to-unexpected-absence/boot, cap admission and retained daily-deferral restart rows remain unproved. Unit checks do not replace those rows. Cumulative interface scope requires assessment; matching original approval evidence was not supplied to this lane, and no approval/exemption is claimed.
Objections: F1 (high): a supported daily rearm is overwritten by an older denied occurrence.
Conclusion: Hold for F1; this review grants no approval or release readiness.
F1 — Preserve a newer daily rearm when deferring an older denied claim
v2/src/session-service.ts:5691 and 5717-5722 compare schedule values and unchanged lifecycle revision, then restore the old occurrence. At 09:00:01 the scheduler advances the due 09:00 occurrence to 09:40. A concurrent supported POST /sessions/:id/wake rearms the same dailyAt/message/condition at 09:00:02 for 09:40, while the admission-deferral write waits for its lock. scheduleWake does not advance the lifecycle revision. The old denial therefore accepts the equal-valued new schedule and replaces it with nextDueAt=09:15:01 and admissionDeferredOccurrence=09:00. The old occurrence can run before the newly requested slot when capacity returns. Bind deferral to the actual claim and invalidate it on schedule replacement/cancellation, including equal public values; preserve unrelated queue/metadata writes.
Reproduction: the artifact-only independent probe calls actual service.scheduleWake through the same method used by server.ts:1912, with two distinct update timestamps. Its metadata write trace shows claim09:40 -> rearm09:40 -> stale retry09:15:01+old09:00. The equal-value rearm fails; changing the new message passes. No checkout source or test file was edited. This deferral helper is introduced by this PR and absent at B.
Evidence: code-c02-confirmation.log, code-reviewer-probes.config.ts, code-targeted.log, code-build.log, code-source-fingerprint.json, code-review-result.md. Coverage: independent native agent coverage-challenge-review-6bd4 (independent native delegate; identity mapping retained in evidence); code-coverage-draft.md -> code-coverage-challenge.md -> code-coverage-final.md. Six omissions received explicit rows or bounded exclusions before execution. Missing native rows are not marked passed. Browser flows excluded: no visible web changes. The separate expired-retry characterization remains a policy question and is not a second finding.
Contract identity and evidence: lane code; session review-6bd4; attempt code-review-6bd4-1197-20261016t132532z-a6199d6a; H c31d594; B 21e5796; contract SHA256 0c9036cfca50fa34adc518948f3c81ac52a5a77fdddea571e533da1b9586ccfc.
Spur review attempt: code-review-6bd4-1197-20261016t132532z-a6199d6a
Lane: code
H: c31d594
B: 21e5796
ContractDigest: 0c9036cfca50fa34adc518948f3c81ac52a5a77fdddea571e533da1b9586ccfc
Status: CHANGES_REQUESTED
Scenario evidence: [{"status":"failed","evidence":"F1/R22 supported equal-value rearm race; code-c02-confirmation.log; SHA256 634819eba83b828902763ffbe1b68844d6e41324a49f980e6ddaeec97dfd483b"},{"status":"passed","evidence":"R22 changed-message rearm control passes in same confirmation run."},{"status":"passed","evidence":"318 selected current-H probe/historical/boot/nonrunning/wake-admission unit checks pass; code-targeted.log SHA256 c676fa86145d4b26af805b1cd1ad7b945b1cfd452ecfd2257143be103dc3d889"},{"status":"passed","evidence":"Relevant v2 package build exit 0 with SPUR_BUILD_RESTART=0; clean source fingerprint code-source-fingerprint.json."}]
Coverage: {"challenger":"coverage-challenge-review-6bd4","output":"Independent native agent coverage-challenge-review-6bd4 (independent native delegate; identity mapping retained in evidence); code-coverage-challenge.md. Six omissions C01-C06 dispositioned before execution in code-coverage-final.md; final rows and remaining live evidence gaps in code-review-result.md.","omissionsClosed":true}
Written by Spur · review-6bd4
|
Code review: changes requested — See the native review. Written by Spur · review-6bd4 |
|
Browser review: blocked — Required review checks incomplete. Written by Spur · review-d0ae |
|
Browser review: pending. Written by Spur · review-d0ae |
|
Code review: pending. Written by Spur · review-6bd4 |
|
Browser review: blocked — Required review checks incomplete. Written by Spur · review-d0ae |
|
Code review: blocked — Required review checks incomplete. Written by Spur · review-6bd4 |
…s-restart # Conflicts: # v2/src/session-service.ts # v2/test/fast/session-service.test.ts
Classification of a record with no persisted file reached the observation fence, which threw not-found and failed cursor classification and desk member enrichment.
|
Browser review: pending. Written by Spur · review-4be9 |
|
Code review: pending. Written by Spur · review-9b69 |
|
Browser review: pending. Written by Spur · review-4be9 |
There was a problem hiding this comment.
Browser QA Conclusion
Conclusion: APPROVED. The only change since the approved 7d91e47 is one line in a test fixture: the external lifecycle action is now the valid complete instead of the invalid stop. No runtime or UI behavior changed.
Lane: browser/manual. Session: review-4be9. Attempt: browser-review-4be9-1197-acf-20261106t194950z.
H: acfa9d0. B: 63690e4.
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702.
History: APPROVED 5805679657 at 7d91e47, which carried the canonical manifest. It is superseded by this head.
DELTA 7d91e47..acfa9d0
Only v2/test/fast/session-service.test.ts:34263 changed: internals.lifecycle.begin("stop", ...) became begin("complete", ...).
LifecycleActionis"complete" | "restore" | "reopen"(v2/src/types.ts:1359), so"stop"was a type error.- The reboot-restore fence compares lifecycle instance and revision, not the action. The test still proves that an external operation fences the later sibling, which matches the live R8c row (real external
complete). - No source, docs or config file changed.
Scenario evidence
- T1 passed at H:
vitest run --config vitest.fast.config.ts test/fast/session-service.test.ts -t "restoreRebootedSessions|shared-workspace sibling|external lifecycle". Exit 0, 7 passed. - Runtime rows are retained from 7d91e47, because no source changed:
- R8a/R8b: owner-first and sibling-first reboot restore both bring back the two shared-workspace members.
- R8c: an external
completefences the later sibling. - R1, R2, R3, R5, R6: wake deferral, daily marker, restart, exhaustion, probe-error boot heal.
- N3: wake reservation counted as exactly one slot.
- Static review passed: N1, N2, N3 and F1, F2, F3 stay fixed.
Exclusions
- Browser walkthrough rows are not required: B..H touches no
packages/webfile and no UI flow changed. - No CI read. No local build, full typecheck, lint or full suite.
Interface
Assessment status: required. The canonical manifest agreed with the code lane is unchanged: manifestDigest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baselineDigest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d.
This technical approval does not establish interface consent.
Objections: none
Spur review attempt: browser-review-4be9-1197-acf-20261106t194950z
Lane: browser
H: acfa9d0
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"T1 exact H: session-service fence selection 7 passed, exit 0"},{"status":"passed","evidence":"Delta static: test fixture stop->complete valid LifecycleAction; fence semantics unchanged; no source change"},{"status":"passed","evidence":"R8a/R8b/R8c live retained from 7d91e47 (no source delta): both members restored either order; external complete fences sibling"},{"status":"passed","evidence":"R1 R2 R3 R5 R6 N3 live retained (session-service.ts unchanged)"},{"status":"passed","evidence":"Static: N1 N2 N3 F1 F2 F3 fixed"}]
Coverage: null
Written by Spur · review-4be9
|
Browser review: approved. Written by Spur · review-4be9 |
|
Code review: pending. Written by Spur · review-9b69 |
There was a problem hiding this comment.
Code Review Conclusion
Status: APPROVED
Lane: code. Session: review-9b69. Attempt: code-review-9b69-1197-acf-20261106t194954z-103019ea
H: acfa9d0 B: 63690e4
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Delta reviewed: 7d91e47 to H, one line in v2/test/fast/session-service.test.ts (canonical diff digest fdcc41b0cdd628dd5d274a7d013242fdee9900b31a4ea86d54548373d22e6848). The external lifecycle operation in the shared-workspace fence test now begins "complete" instead of "stop"; "stop" is not a LifecycleAction (types.ts: complete | restore | reopen), "complete" is. Begin/settle still bumps the owner revision, so the fence scenario and every assertion are unchanged. No source change.
Checks: fence test alone 1 passed; session-service.test.ts boot/reconcile/restore selection 202 passed. Typecheck, lint, build, e2e not run (CI-owned). No CI queried. No source edits.
Requirements: covered.
Objections: none
History: this lane's prior approval at 7d91e47 (reviews 5805314310, 5805704724) covered all source; source files are byte-identical at H, so that evidence (startServer reorder, reboot restore owner-first, sibling-first and external fence, live rows, N1-N3) is retained.
Scenario evidence: shared-workspace sibling skipped by an external lifecycle operation, logs session.reboot.restore.aborted lifecycle_changed: passed at H. Boot reconcile and reboot restore selection: passed at H.
Exclusions: no UI change; no runtime change, live rows retained from the prior head.
Missing: none.
Interface: assessment required, manifest unchanged and identical to the browser lane (manifest digest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baseline digest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d), 15 per-file dispositions set-equal to PR files. Interface consent evidence was not supplied to this lane; none is claimed; matching consent stays an owner-gate requirement.
Conclusion: test-only type repair; code lane approves this head. No merge or release authority granted.
Spur review attempt: code-review-9b69-1197-acf-20261106t194954z-103019ea
Lane: code
H: acfa9d0
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"Fence test with valid complete action 1 passed at H; t4-fence.log SHA256 e48564abffebae171182440766ecc93ce4fc2a548f7264b6f25fc5d8778114e8"},{"status":"passed","evidence":"session-service boot/reconcile/restore selection 202 passed at H; t3-session-filter.log SHA256 92502c4010e6f2270a1bdacea70cda558b06ae758a1c7d9387d243b38e72c57d"},{"status":"passed","evidence":"Delta digest fdcc41b0cdd628dd5d274a7d013242fdee9900b31a4ea86d54548373d22e6848, test-only; source byte-identical to prior approved head 7d91e47"},{"status":"passed","evidence":"Retained at unchanged source: startServer reorder tests 16, mcp-contracts+server-shutdown 46, probes 7, live reboot restore owner-first/sibling-first/external fence, wake admission live rows"}]
Coverage: null
Written by Spur · review-9b69
|
Code review: approved. Written by Spur · review-9b69 |
|
Code review: pending. Written by Spur · review-9b69 |
|
Browser review: pending. Written by Spur · review-4be9 |
|
Code review: pending. Written by Spur · review-9b69 |
There was a problem hiding this comment.
Code Review Conclusion
Status: APPROVED
Lane: code. Session: review-9b69. Attempt: code-review-9b69-1197-aeb-20261106t202913z-ed1cfce1
H: aeb62f7 B: 63690e4
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Delta reviewed: acfa9d0 to H, v2/test/fast/server.test.ts only (canonical diff digest a2fe4be64507c00a90db3c6c27ca5a3af64749e947a8e461b195f7dec7b8119a). The startServer event-order test now expects daemon.startup.reconciled before the attention gh.poll_cycle and asserts that ordering explicitly, matching the source change that starts background loops after boot reconcile. Assertions are stricter, not weaker. No source change.
Checks: server.test.ts 92 passed. Typecheck, lint, build, e2e not run (CI-owned). No CI queried. No source edits.
Requirements: covered.
Objections: none
History: this lane's approvals at 7d91e47 and acfa9d0 (reviews 5805704724, 5806109836) covered all source; source files are byte-identical at H, so that evidence (startServer reorder, reboot restore owner-first, sibling-first and external fence, live rows, N1-N3) is retained.
Scenario evidence: startServer startup event order with boot reconcile before background polling: passed at H.
Exclusions: no UI change; no runtime change, live rows retained.
Missing: none.
Interface: assessment required, manifest unchanged and identical to the browser lane (manifest digest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baseline digest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d), 15 per-file dispositions set-equal to PR files. Interface consent evidence was not supplied to this lane; none is claimed; matching consent stays an owner-gate requirement.
Conclusion: test-only alignment; code lane approves this head. No merge or release authority granted.
Spur review attempt: code-review-9b69-1197-aeb-20261106t202913z-ed1cfce1
Lane: code
H: aeb62f7
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"server.test.ts 92 passed at H incl. startup event order reconcile before attention poll; t1-server.log SHA256 7394610d6920dbf0e3c63092b6392ddc6dd105f274771e9043791c7b7c593a40"},{"status":"passed","evidence":"Delta digest a2fe4be64507c00a90db3c6c27ca5a3af64749e947a8e461b195f7dec7b8119a, test-only; source byte-identical to prior approved heads"},{"status":"passed","evidence":"Retained at unchanged source: fence test, boot selection 202, startServer reorder tests 16, mcp-contracts+server-shutdown 46, probes 7, live reboot restore and wake admission rows"}]
Coverage: null
Written by Spur · review-9b69
|
Code review: approved. Written by Spur · review-9b69 |
|
Browser review: pending. Written by Spur · review-4be9 |
There was a problem hiding this comment.
Browser QA Conclusion
Conclusion: APPROVED. The only change since the approved acfa9d0 is v2/test/fast/server.test.ts, which now expects boot reconcile to finish before the background loops start. That order is what the 7d91e47 fix implements. No runtime or UI behavior changed.
Lane: browser/manual. Session: review-4be9. Attempt: browser-review-4be9-1197-aeb-20261106t202933z.
H: aeb62f7. B: 63690e4.
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702.
History: APPROVED 5806085758 at acfa9d0 is superseded by this head.
DELTA acfa9d0..aeb62f7
Only v2/test/fast/server.test.ts:529-546 changed.
- The startup test now expects
daemon.startup.reconciled(scanned/alive/drifted 0) before the attentiongh.poll_cycle. - It checks this two ways: by comparing the two event indices, and by the exact ordered event list.
- Before this change, the test still expected the old order, with the poll before reconcile. It now matches
startBackgroundLoopsrunning afterreconcileStoppedSessions(server.ts:2696). - No source, docs or config file changed.
Scenario evidence
- T1 passed at H:
vitest run --config vitest.fast.config.ts test/fast/server.test.ts. Exit 0, 92 passed. - Runtime rows are retained from 7d91e47, because no source changed since:
- R8a/R8b/R8c: reboot restore of shared-workspace members, plus the external-complete fence.
- R1, R2, R3, R5, R6: wake deferral, daily marker and restart, exhaustion, probe-error boot heal.
- N3: a waking session holds exactly one admission slot.
- Static review passed: N1, N2, N3 and F1, F2, F3 stay fixed. The acfa9d0 fixture fix is retained.
Exclusions
- Browser walkthrough rows are not required: B..H touches no
packages/webfile and no UI flow changed. - No CI read. No local build, full typecheck, lint or full suite.
Interface
Assessment status: required. The canonical manifest agreed with the code lane is unchanged: manifestDigest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baselineDigest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d. The dispositions now cover all 16 PR files.
This technical approval does not establish interface consent.
Objections: none
Spur review attempt: browser-review-4be9-1197-aeb-20261106t202933z
Lane: browser
H: aeb62f7
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"T1 exact H: server.test.ts 92 passed, exit 0"},{"status":"passed","evidence":"Delta static: startup event order test aligned to boot reconcile before background loops; no source change"},{"status":"passed","evidence":"R8a/R8b/R8c live retained from 7d91e47 (no source delta)"},{"status":"passed","evidence":"R1 R2 R3 R5 R6 N3 live retained (session-service.ts unchanged)"},{"status":"passed","evidence":"Static: N1 N2 N3 F1 F2 F3 fixed; acfa9d0 fixture fix retained"}]
Coverage: null
Written by Spur · review-4be9
|
Browser review: approved. Written by Spur · review-4be9 |
|
Code review: pending. Written by Spur · review-9b69 |
|
Code review: pending. Written by Spur · review-9b69 |
There was a problem hiding this comment.
Code Review Conclusion
Status: APPROVED
Lane: code. Session: review-9b69. Attempt: code-review-9b69-1197-aeb-cov-20261106t203125z-e5a0e67e
H: aeb62f7 B: 63690e4
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Delta reviewed: acfa9d0 to H, v2/test/fast/server.test.ts only (canonical diff digest a2fe4be64507c00a90db3c6c27ca5a3af64749e947a8e461b195f7dec7b8119a). The startServer event-order test now expects daemon.startup.reconciled before the attention gh.poll_cycle and asserts that ordering explicitly, matching the source change that starts background loops after boot reconcile. Assertions are stricter, not weaker. No source change.
Checks: server.test.ts 92 passed. Typecheck, lint, build, e2e not run (CI-owned). No CI queried. No source edits.
Requirements: covered.
Objections: none
History: this lane's approvals at 7d91e47 and acfa9d0 (reviews 5805704724, 5806109836) covered all source; source files are byte-identical at H, so that evidence (startServer reorder, reboot restore owner-first, sibling-first and external fence, live rows, N1-N3) is retained.
Scenario evidence: startServer startup event order with boot reconcile before background polling: passed at H.
Exclusions: no UI change; no runtime change, live rows retained.
Missing: none.
Interface: assessment required, manifest unchanged and identical to the browser lane (manifest digest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baseline digest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d), 16 per-file dispositions set-equal to PR files (v2/test/fast/server.test.ts is new to the PR at this head). This supersedes this lane's review 5806582737 at the same head, whose assessment listed 15 dispositions and omitted v2/test/fast/server.test.ts; verdict and checks unchanged. Interface consent evidence was not supplied to this lane; none is claimed; matching consent stays an owner-gate requirement.
Conclusion: test-only alignment; code lane approves this head. No merge or release authority granted.
Spur review attempt: code-review-9b69-1197-aeb-cov-20261106t203125z-e5a0e67e
Lane: code
H: aeb62f7
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"server.test.ts 92 passed at H incl. startup event order reconcile before attention poll; t1-server.log SHA256 7394610d6920dbf0e3c63092b6392ddc6dd105f274771e9043791c7b7c593a40"},{"status":"passed","evidence":"Delta digest a2fe4be64507c00a90db3c6c27ca5a3af64749e947a8e461b195f7dec7b8119a, test-only; source byte-identical to prior approved heads"},{"status":"passed","evidence":"Assessment dispositions 16, set-equal to PR files at H"},{"status":"passed","evidence":"Retained at unchanged source: fence test, boot selection 202, startServer reorder tests 16, mcp-contracts+server-shutdown 46, probes 7, live reboot restore and wake admission rows"}]
Coverage: null
Written by Spur · review-9b69
|
Code review: approved. Written by Spur · review-9b69 |
|
Code review: pending. Written by Spur · review-9b69 |
|
Code review: pending. Written by Spur · review-9b69 |
There was a problem hiding this comment.
Code Review Conclusion
Status: APPROVED
Lane: code. Session: review-9b69. Attempt: code-review-9b69-1197-cfd-20261106t212058z-a0ab7f37
H: cfd827d B: 63690e4
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Delta reviewed: aeb62f7 to H, v2/test/fast/server.test.ts only (canonical diff digest 1be0f3a3a70c0d801f98157171971e8b7e38faf8594ddbf03e802506ed1825a1). Formatting only: one findIndex call wrapped across lines; same predicate, same assertions. No source change; PR file set unchanged (16).
Checks: server.test.ts 92 passed. Typecheck, lint, format check, build, e2e not run (CI-owned). No CI queried. No source edits.
Requirements: covered.
Objections: none
History: this lane's approval at aeb62f7 (review 5806595218) and earlier approvals covered all source; source files are byte-identical at H, so that evidence is retained.
Scenario evidence: startServer startup event order with boot reconcile before background polling: passed at H.
Exclusions: no UI change; no runtime change, live rows retained.
Missing: none.
Interface: assessment required, manifest unchanged and identical to the browser lane (manifest digest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baseline digest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d), 16 per-file dispositions set-equal to PR files. Interface consent evidence was not supplied to this lane; none is claimed; matching consent stays an owner-gate requirement.
Conclusion: format-only test change; code lane approves this head. No merge or release authority granted.
Spur review attempt: code-review-9b69-1197-cfd-20261106t212058z-a0ab7f37
Lane: code
H: cfd827d
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"server.test.ts 92 passed at H; t1-server.log SHA256 4010e425a718c6723eb5b13afcad08e605439617669476a3580929e718ee3063"},{"status":"passed","evidence":"Delta digest 1be0f3a3a70c0d801f98157171971e8b7e38faf8594ddbf03e802506ed1825a1, format-only test change; source byte-identical to prior approved heads"},{"status":"passed","evidence":"Assessment dispositions 16, set-equal to PR files at H"},{"status":"passed","evidence":"Retained at unchanged source: fence test, boot selection 202, startServer reorder tests 16, mcp-contracts+server-shutdown 46, probes 7, live reboot restore and wake admission rows"}]
Coverage: null
Written by Spur · review-9b69
|
Code review: approved. Written by Spur · review-9b69 |
|
Browser review: pending. Written by Spur · review-4be9 |
|
Browser review: pending. Written by Spur · review-4be9 |
There was a problem hiding this comment.
Browser QA Conclusion
Conclusion: APPROVED. The only change since the approved aeb62f7 is formatting in v2/test/fast/server.test.ts: one findIndex call is wrapped across lines. No runtime, test-semantics or UI change.
Lane: browser/manual. Session: review-4be9. Attempt: browser-review-4be9-1197-cfd-20261106t212301z.
H: cfd827d. B: 63690e4.
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702.
History: APPROVED 5806587541 at aeb62f7 is superseded by this head.
DELTA aeb62f7..cfd827d
v2/test/fast/server.test.ts:532: events.findIndex((entry) => entry.event === "daemon.startup.reconciled") is split across three lines. The expression and the assertions are unchanged.
Scenario evidence
- T1 passed at H:
vitest run --config vitest.fast.config.ts test/fast/server.test.ts. Exit 0, 92 passed. - Runtime rows are retained from 7d91e47, because no source changed since:
- R8a/R8b/R8c: reboot restore of shared-workspace members, plus the external-complete fence.
- R1, R2, R3, R5, R6: wake deferral, daily marker and restart, exhaustion, probe-error boot heal.
- N3: a waking session holds exactly one admission slot.
- Static review passed: N1, N2, N3 and F1, F2, F3 stay fixed. The acfa9d0 and aeb62f7 test fixes are retained.
Exclusions
- Browser walkthrough rows are not required: B..H touches no
packages/webfile and no UI flow changed. - No CI read. No local build, full typecheck, lint or full suite.
Interface
Assessment status: required. The canonical manifest is unchanged: manifestDigest d0cd5636c885bd3b41aec5b173220575ad03b4c4f2bb3d233cb6a48afd198039, baselineDigest 6c9d54baa94c319600c0ca026930d0a2bba6a42cdd2f440723b95d186037776d. The dispositions cover all 16 PR files.
This technical approval does not establish interface consent.
Objections: none
Spur review attempt: browser-review-4be9-1197-cfd-20261106t212301z
Lane: browser
H: cfd827d
B: 63690e4
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"T1 exact H: server.test.ts 92 passed, exit 0"},{"status":"passed","evidence":"Delta static: format-only line wrap in server.test.ts; no source change"},{"status":"passed","evidence":"R8a/R8b/R8c live retained from 7d91e47 (no source delta)"},{"status":"passed","evidence":"R1 R2 R3 R5 R6 N3 live retained (session-service.ts unchanged)"},{"status":"passed","evidence":"Static: N1 N2 N3 F1 F2 F3 fixed; acfa9d0 and aeb62f7 test fixes retained"}]
Coverage: null
Written by Spur · review-4be9
|
Browser review: approved. Written by Spur · review-4be9 |
Probe recovery recognizes the same two exact historical diagnostics for healthy runtime recovery and independently confirmed native absence. Affected dead sessions move from running to stopped, disabling the queued-message runner. Both versions exclude these historical-error subjects from boot restore; recovery preserves runtime ownership checks, scheduled wake admission and durable daily deferrals.
Final-revision local code review passed. Independent targeted runs passed 304 and 337 cases; groups overlap. The same baseline tests produced seven expected failures and four passing causal controls. Package build, typecheck and lint passed. Earlier developer fixture failures and one timeout remain recorded; corrected focused checks passed, and the final independent run passed those sequences.
Missing: a genuine affected native diagnostic followed by independently confirmed unexpected absence and boot behavior. Durable UNKNOWN-operation once-only execution is not proven; inherited post-dispatch handling requeues the attempted input and removes its typed receipt baseline. Local state-recovery tests do not establish safe later execution. Strict CI and fresh pinned review remain pending. Separate historical-idle delivery and combined durable-uncertainty restart proofs remain open; this update claims neither approval nor release readiness.