Fix: Replace avx2vnni with avxvnni for GCC and Clang compatibility #296
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungWonYang-pro
force-pushed
the
fix/sierra-avxvnni-pragma
branch
from
b40648d to
5193189
Compare
SeungWonYang-pro
changed the title
SeungWonYang-pro
changed the title
GCC and Clang do not recognize the target attribute. The correct flag for AVX-VNNI (AVX2-VNNI) instructions is . This fix enables SIMSIMD_TARGET_SIERRA to compile successfully with both GCC and Clang, allowing runtime dispatch to select optimal SIERRA kernels on compatible CPUs. Changes: - include/simsimd/dot.h: avx2vnni -> avxvnni in pragma directives - include/simsimd/spatial.h: avx2vnni -> avxvnni in pragma directives Tested with: - GCC 15.2.0 - Clang 20.1.8
SeungWonYang-pro
force-pushed
the
fix/sierra-avxvnni-pragma
branch
from
5193189 to
0b5df10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
issue #295
Summary
Fixes compiler compatibility by correcting the pragma target attribute from avx2vnni to avxvnni for GCC and Clang compilers.
Problem
The target attribute name
avx2vnniis incorrect. The correct name isavxvnni(AVX-VNNI instruction set extension). This typo could cause compilation errors with certain compiler versions.Solution
Replaced all occurrences of
avx2vnniwithavxvnniin Sierra target pragma directives across both files.