Skip to content

feat(plugins): server plugins can post notes into threads - #27

Draft
ashx-j wants to merge 18 commits into
mainfrom
feat/plugins-notify
Draft

ashx-j wants to merge 18 commits into
mainfrom
feat/plugins-notify

Conversation

@ashx-j

@ashx-j ashx-j commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Part of Phase 3 of the plugin system roadmap (#3, phase issue #7). It builds on #26, so until #14 to #26 merge this diff also shows their commits.

A plugin had no way to post into a thread without starting an agent turn, because every message.dispatch starts a run. Now api.threads.notify adds a note to the thread and nothing else happens. Ash approved the change to Orchestrator.ts this needs, as an exception to decision 3, on the condition that no other feature changes.

  • api.threads.notify({ threadId, summary, detail?, outcome? }) adds a note that starts with the plugin's name. It starts no turn, isn't sent to the agent as a message, and doesn't mark the thread unread.
  • The plugin host sends a new internal command, thread.notification.record, which clients can't send. The orchestrator files the note as an ordinary notification item, so web, desktop and the store mobile apps already render it.
  • The note joins the thread's latest finished run. T3 sorts items that have no run before every run, and clients drop them from paged threads. A note inside a running turn would split that turn's live output.
  • packages/plugin-sdk/examples/thread-digest is the first example plugin, kept in this repo instead of a separate one. After each run it notes how the run ended and how long it took.
  • Also: knip treats example entries like fixtures, and a lint warning from fix(plugins): second review fixes for installs, npm, the run hook and the loader #26 in pluginTarball.ts is fixed.

Measurements: nothing runs unless a plugin calls notify. The orchestrator gains one case in its command switch.

Test plugin: thread-digest, installed from its folder on the Plugins page.

Verification:

  • Orchestrator.control-reads.test.ts: a note joins the finished run after that run's items, a later unfinished run doesn't get it, and no run starts.
  • PluginHost.test.ts: notify sends the command with the plugin's name in front of the summary.
  • In the dev app with a seeded copy of real data, I installed thread-digest from Settings and ran a Replay turn. "Thread digest: Run finished in 6 s" appeared under the run.
  • vp run check:changed passed.
  • Not verified: how the note looks on mobile, and a note sent while a turn is running.

Screenshot: GitHub's CLI can't upload images, so the screenshot of the note is in the T3 thread for this work (plugin-notify.png). It still needs to be dragged into this description during review.


PR filed by Claude Opus 5.5 in Claude Code through T3 Code.

ashx-j and others added 18 commits October 31, 2026 21:22
…bility flag

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PluginHost discovers installed and dev plugins, loads enabled CommonJS
entries after the server is listening, and hands each a Promise-based API
for logging, settings, storage, RPC methods and channels. Failures mark the
plugin failed and never stop the server. Settings live beside T3's state
with secrets in the server secret store; storage is a lazily opened SQLite
file. Eight plugins.* WebSocket methods manage plugins, and the environment
advertises plugins: true.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An adversarial review found that reloading one plugin left plugins whose
folders vanished running, that a caller disconnecting mid-disable left a
plugin half torn down but still routed, that a misspelled access level
made a write method callable by read-only sessions, and that reload kept
old code for symlinked plugin folders. Lifecycle changes now run in the
host's scope, vanished plugins are stopped, access must be read or write,
and discovery resolves real paths. Activation and cleanups get deadlines,
calls stop routing before teardown, and plugins.json keeps unknown keys.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings gains a Plugins page for the selected environment: each plugin
with its status, failure, enable switch and reload, plus a settings form
generated from the manifest's JSON Schema with write-only secret fields
and a JSON fallback. The page follows plugins.subscribeStates only while
open; the form model lives in client-runtime for the later mobile screen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng and send hooks

Plugins can now follow stored orchestration events by type, read and act
on threads and projects, run scheduled work, see and extend outgoing
messages before they are sent, offer MCP tools to agents and serve HTTP
routes under /api/plugins/<id>, and read the server's version, descriptor
and redacted settings. The send hook runs in ThreadManagementService.dispatch
with a 2 s deadline and fails open; with no hooks it is one Ref read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… writes

An adversarial review found that a send hook appending to /goal clear
turned it into setting a goal, that the SDK promised a veto nothing
honoured, that several event types merged out of sequence order, that a
schedule could outlive its plugin, and that plugin write tools skipped the
caller's mode limits. Hooks now skip slash commands, veto is gone from the
SDK, multi-type event streams stay ordered, schedules and hooks stop on
the deactivation signal, API calls end after cleanups, plugin write tools
need full access like environment writes, and tool schemas must be objects.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Plugins could only run on the server. The server now serves each active
plugin's web bundle, and the web app loads it once an active plugin has a
web part: a starter follows plugin state after idle, and the loader fetches
bundles with the connection's credentials and imports them from blob URLs.
Bundles share the app's React, atom hooks and UI kit through a host object.

Plugins can add right panels, listed in the add menu and the empty panel,
and replace their generated settings form. An unloaded plugin's panel shows
"Plugin not active" with a close button. The desktop CSP allows blob scripts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Web plugins could add panels but nothing users could run from the
keyboard. Plugins can now register command palette commands that users
bind as plugin.<pluginId>.<commandId>, and slash commands in the composer
that run plugin code. They can also navigate and load files from their
assets folder, which the server serves under /api/plugins/<id>/assets/*.

The SDK gains a Vite preset that builds web.js against T3's React and UI
kit, keeping only the names a plugin uses, and typed UI components.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…om plugins

Web plugins could add panels and commands but not change how T3 looks or
how conversations read. A plugin's themes/ folder is now published through
the environment theme service, so its themes reach every client. Web
plugins can show composer banners, draw their own MCP tool calls in the
timeline, draw fenced code of a language in chat messages, and inject
styles. Everything is removed when the plugin unloads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tools

Plugins could see a message before it was sent but not what happened
after, and agents could list plugins but not use them.

turns.afterRunCompleted delivers every ended run in order, saving its
position in the plugin's storage so runs that end while the plugin is off
arrive when it starts. turns.beforeDispatch now gets the message id,
attachment summaries and the requested model. Agents get
t3_plugins_invoke and t3_plugins_set_enabled, gated as writes and only
advertised once a plugin is installed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Plugins had to be copied into the data folder by hand or listed as dev
folders. plugins.install now takes a folder on the server or a git
repository, stages it, checks the manifest and swaps it into place with a
rename, keeping the previous version if anything fails. plugins.uninstall
stops and deletes a plugin, keeping its data unless asked otherwise.

Settings → Plugins gets an Add plugin form and a remove action, agents get
t3_plugins_install and t3_plugins_uninstall, a user guide explains it, and
the SDK gets a README for plugin authors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An adversarial review of the plugin stack found 10 issues. Uninstalling a
symlinked plugin deleted the folder behind the link. afterRunCompleted
delivered interrupted runs twice and could skip runs while catching up.
A cancelled install could race its own swap, and a crash mid-swap lost
the plugin. The web loader leaked registrations made after unload, let
one stuck plugin block the rest, kept stale code after a same-version
reload, and added a shortcut handler before any plugin command existed.
Plugin tool renderers only matched Codex tool names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
api.threads.notify adds a notification item to a thread without starting a run,
through a new internal orchestrator command that files the note under the
thread's latest finished run. Adds the thread-digest example plugin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ashx-j
ashx-j force-pushed the feat/plugins-notify branch from 2f67e67 to 29d0964 Compare October 31, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant