feat: capture parity for Svelte/Solid + Angular and MCP guides#341
Merged
Conversation
…ectionCapture Brings Svelte and Solid to full capture parity with React: - useAskableRegionCapture — rect/circle/lasso region selection - useAskableTextSelectionCapture — highlighted text capture Svelte 5 implementations use $state/$effect runes and return reactive getter objects. Solid implementations use createSignal/createEffect with accessor functions following the existing hook patterns. Both hooks are exported from the ./core sub-path barrel and added to package.json exports/files for Svelte. Svelte tsconfig exclude list updated to keep the .svelte.ts files out of tsc compilation.
- Angular guide covers AskableService, [askable] directive, AskableModule, cart/multistep sources, agent requests, region/text capture, and SSR safety - MCP guide covers browser-local page bridge, remote WebMCP with Next.js and Express examples, authorization, client setup (Claude Desktop, Claude.ai, ChatGPT), and in-process MCP server embedding - Both guides wired into the sidebar (Framework Guides + Integrations sections) - Docs homepage updated with direct links to both guides
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@askable-ui/angular
@askable-ui/context
@askable-ui/core
@askable-ui/create-app
@askable-ui/mcp
@askable-ui/qwik
@askable-ui/react
@askable-ui/react-native
@askable-ui/solid
@askable-ui/svelte
@askable-ui/vue
@askable-ui/web-component
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAskableRegionCaptureanduseAskableTextSelectionCapturewere the only two hooks missing from Svelte and Solid (both had full parity otherwise). Both are now implemented and exported.AskableService,[askable]directive,AskableModule, all major sources (cart, multistep, etc.), agent requests, region/text capture, and SSR safety.Changes
@askable-ui/sveltesrc/useAskableRegionCapture.svelte.ts— Svelte 5 runes implementation (reactive$stategetters,$effectcleanup)src/useAskableTextSelectionCapture.svelte.ts— same pattern withcaptureNowsupportsrc/core.svelte.ts— exports both new hookstsconfig.json— adds both files to exclude list (.svelte.tsimports not valid in plain tsc)package.json— adds individual sub-path exports and entries infiles@askable-ui/solidsrc/useAskableRegionCapture.ts— SolidJS implementation usingcreateSignal/createEffect/onCleanupsrc/useAskableTextSelectionCapture.ts— same pattern withcaptureNowsupportsrc/core.ts— exports both new hookssrc/index.ts— exports both hooks and their typesDocs
site/docs/guide/angular.md— new Angular framework guidesite/docs/guide/mcp.md— new MCP integration guidesite/docs/.vitepress/config.ts— Angular added to Framework Guides, MCP added to Integrationssite/docs/index.md— links to both new guidesTest plan
cd packages/svelte && npm run build— should compile without errors (new files excluded from tsc, consumed by Vite directly)cd packages/solid && tsc --noEmitcd site/docs && npm run build— Angular and MCP pages render correctly/guide/angularand/guide/mcpin local dev and verify sidebar links appearGenerated by Claude Code