chore: bump vite-plus to ^0.3.1 - #42
Merged
Merged
Conversation
vite-plus 0.3.1 changes how it depends on Vite: 0.3.0 depended on @voidzero-dev/vite-plus-core under its own name, while 0.3.1 depends on it via the alias "vite": "npm:@voidzero-dev/vite-plus-core@0.3.1". As a result `vp pack` now hard-requires the project's own node_modules/vite to be that same alias, and fails otherwise: Expected @voidzero-dev/vite-plus-core@0.3.1, but found vite@8.2.2 So the devDependency on vite is aliased to match. This is the same vite dependency alignment `vp migrate` performs, applied by hand to keep the change scoped to dependencies (a full `vp migrate` also rewrites AGENTS.md, editor config, and pre-commit hooks, which is out of scope here). Both peerDependencies ranges are intentionally left alone: - vite-plus "^0.2.8 || ^0.3.0" already admits 0.3.1, and narrowing it would be a breaking change for consumers still on 0.2.x. - vite "^8.2.2" describes what consumers bring; they install real Vite, not the vite-plus core distribution. The alias is a development-only concern. fmt, lint, build, test (67 passing), typecheck, and publint all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
vite-plusdevDependency from^0.3.0to^0.3.1.package-lock.jsonresolvesvite-plusat0.3.1(verified against the installed tree, not just the manifest).Why the
vitedevDependency also changedvite-plus 0.3.1 changed how it depends on Vite. 0.3.0 depended on
@voidzero-dev/vite-plus-coreunder its own package name; 0.3.1 depends on it through an alias:Because of that,
vp packnow hard-requires the project's ownnode_modules/viteto be the same alias, and fails the build otherwise:So the
vitedevDependency is aliased to match. This is the same Vite alignmentvp migrateperforms, applied by hand to keep the diff scoped to dependencies — a fullvp migratealso rewritesAGENTS.md, editor config, and pre-commit hooks, none of which belong in a version bump.Worth flagging for review: this arrived in a patch release, but it is a breaking change in what vite-plus requires of the host project.
Peer dependency ranges: deliberately unchanged
Neither peer range was touched.
vite-plus: "^0.2.8 || ^0.3.0"—^0.3.0already admits0.3.1, so no change is needed to consume the new version. Narrowing it to^0.3.1would break anyone on 0.2.x for no benefit.vite: "^8.2.2"— this describes what consumers bring. They install real Vite 8; the vite-plus core distribution is a development-only concern of this repo. Propagating the alias into the peer contract would be a breaking change for every consumer.Checks
Ran the full CI sequence locally. All green:
fmt --checklintbuildtesttypechecktest:publintNothing needed fixing beyond the alias.
Pre-existing failure, not fixed here
npm run pack:checkfails, and it fails identically on a cleanorigin/maincheckout — it is unrelated to this bump and left alone.tests/package-artifacts.jsparsesnpm pack --ignore-scripts --dry-run --jsonand expects a top-level array:Under npm 12 (
packageManageris pinned tonpm@12.0.1) that command no longer returns an array, soresult.lengthisundefined. It is not part of the CI workflow — CI runs fmt, lint, build, test, and typecheck — so it does not gate this PR, but it does gatenpm run checkandprepublishOnly. Worth a separate fix.