Splits the ErrorBadPathName exception into three separate exceptions (empty, malformed, & extension not registered) #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(empty, malformed, & extension not registered) This level of detail would have helped make what happened in #330 obvious. Deprecates ErrorBadPathName in favour of ErrorPathNameEmpty, ErrorPathNameMalformed, and ErrorPathNameExtensionNotRegistered. Note that ErrorPathUndefined is another case that can happen (valid path, not defined).
asmaloney
force-pushed
the
split-bad-path-name-exception
branch
from
2dfb309 to
b86484d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This level of detail would have helped make what happened in #330 obvious.
Deprecates ErrorBadPathName in favour of ErrorPathNameEmpty, ErrorPathNameMalformed, and ErrorPathNameExtensionNotRegistered.
Note that ErrorPathUndefined is another case that can happen (valid path, not defined).