Fix #48, #54 by surfacing likely API error conditions to the logs#71
Merged
Merged
Conversation
…I error conditions to the logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for GitHub Issues #48 and #54
Problem Summary
Both issues reported the same error in
dailyClassChecker.pyandclassFeedbackAutomation.py:Occurring at line:
Root Cause
According to the Neon CRM API documentation, the
/events/searchendpoint should always return:{ "searchResults": [...], "pagination": {...} }However, when the API encounters certain error conditions (rate limiting, validation errors, etc.), it may return HTTP 200 with an error response in a different format, such as:
[][{"errorMessage": "..."}]When the
response.json()call parses these error responses, they become Python lists. Then trying to access["searchResults"]on a list fails with the exact error observed.The Fix
Modified three functions in
helpers/neon.pyto add proper error handling:postEventSearch()(line 103)postOrderSearch()(line 197)postAccountSearch()(line 259)Each function now:
searchResultskeyValueErrorwith the actual response content if validation fails