Handle missing openpath ids#79
Merged
Merged
Conversation
Contributor
|
Thank you for quickly addressing this and leaving a thorough and concise description for the record here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OP accounts are created by the script, it sets a openpathid field on the corresponding neon account, so that it's easy to quickly update the OP account in the future.
If the OP account is manually created, or if the script fails to write the openpathid field back, the openpathid field can be missing. This causes the script to fail, since it'll attempt to recreated the OP account and encounter a 400 error.
Instead, detect these cases ahead of time by using the reverse edge (the external_id field on OP accounts is set to the neon account). Then write the OP account id back to the neon account again.
Also: