Schema unification across app and cron#48
Open
epowell wants to merge 4 commits into
Open
Conversation
epowell
changed the title
epowell
force-pushed
the
epowell/schema-unification
branch
from
af2848f to
d9c6c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why:
File
Change
classes-prisma/
Created — single canonical home for schema + migrations
app/prisma/
Removed — was only schema + migrations (no seed file existed)
cron-service/prisma/schema.prisma + migrations/
Removed — only JS source files remain
app/package.json
"schema" → "../classes-prisma/schema.prisma"
cron-service/package.json
"schema" → "../classes-prisma/schema.prisma" (previously pointed to ../app/prisma/ — the first inconsistency)
app/Dockerfile
Build context widened to .; all COPY paths prefixed with app/; COPY classes-prisma/ /usr/src/classes-prisma/ added to both stages
app/Dockerfile.dev
Same context widening; dev volume mount ./classes-prisma:/usr/src/classes-prisma handles hot-reload
cron-service/Dockerfile
Build context widened to .; COPY paths prefixed with cron-service/; COPY classes-prisma/ /classes-prisma/ added (resolves ../classes-prisma from /var/task)
compose.yaml
cron build changed from build: ./cron-service to context: . / dockerfile: cron-service/Dockerfile
compose.dev.yaml
App build context ./app → ., dockerfile Dockerfile.dev → app/Dockerfile.dev; added volume mounts ./classes-prisma:/usr/src/classes-prisma (app) and ./classes-prisma:/classes-prisma (cron); cron build similarly widened.
dockerignore
Created at repo root — replaces the old app/.dockerignore for both services' wider build contexts