Skip to content
This repository was archived by the owner on Jan 8, 2021. It is now read-only.

corlib and JIT updates#3

Closed
ncave wants to merge 1 commit into
aspnet:stevesa/use-v8-protocol-for-debuggingfrom
ncave:stevesa/use-v8-protocol-for-debugging
Closed

corlib and JIT updates#3
ncave wants to merge 1 commit into
aspnet:stevesa/use-v8-protocol-for-debuggingfrom
ncave:stevesa/use-v8-protocol-for-debugging

Conversation

@ncave
Copy link
Copy Markdown
Contributor

@ncave ncave commented Aug 8, 2017

@SteveSanderson

Here are a few fixes and updates to the corlib and JIT:

  • Better C# support (added some missing JIT features, some bug fixes and updates).
  • Added F# support if needed (uses custom FSharp.Core, see here for a working example).
  • Tried my best to keep the corlib light, it's still around 250k (in release mode).
  • Release build assemblies now work too (after JIT bugfixes).

I see you added CLR debugging in the browser, that's awesome!

@SteveSandersonMS
Copy link
Copy Markdown
Member

Thanks for submitting this, and for resolving the merge issues with the latest debug-enabled code!

If it's OK with you, I'm moving your PR back over to the other repo. That's because this repo in the aspnet org is even more experimentally-experimental, and won't be maintained over time.

I think the steps from here are:

  • I'll selectively merge the commits from this repo (under the aspnet org) back to the one on SteveSanderson. Specifically, the features and commits that are sufficiently complete to be maintained without causing trouble.
  • Then I'll merge your PR onto the result of that

@SteveSandersonMS
Copy link
Copy Markdown
Member

Converted to a PR here: SteveSanderson/Blazor#6

@ncave
Copy link
Copy Markdown
Contributor Author

ncave commented Aug 8, 2017

@SteveSandersonMS Thanks, let me know if anything in the code is not self-explanatory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants