fix(timer): use this.hmac_lib instead of bare hmac_lib (ReferenceError) - #500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug préexistant (introduit en
3d408b802026-08-18, refactor sécurité HMAC) :packages/core/timerScheduler.js:36appelaithmac_lib.signMessage(...)nu au lieu dethis.hmac_lib.signMessage(...)(hmac_libest une propriété du module, ligne 11).Impact en prod : chaque exécution d'un composant timer planifié levait
ReferenceError: hmac_lib is not defined, capturée par le.catch(ligne 70) → les workflows planifiés ne tournaient plus depuis le déploiement de ce commit.Fix :
this.hmac_lib. Une ligne. Hors périmètre SB-IDOR-2026-01.